Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EEA0C6FA8E for ; Thu, 2 Mar 2023 16:54:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230147AbjCBQyP (ORCPT ); Thu, 2 Mar 2023 11:54:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230063AbjCBQyM (ORCPT ); Thu, 2 Mar 2023 11:54:12 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F388830EB3; Thu, 2 Mar 2023 08:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677776052; x=1709312052; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DwsJhH9kOHV7GD3CBh4CQOdjsIKuVme3C7GZneWT9P4=; b=SeJCAmKs7u/4uulm2XIxHahugRiqU6PbhMxhUPQ3czrDF0D+ZvWU0jCS x4MGNNA1XJiJx3/cy5bIj5dfYL650VZkNI5ykZV6Vjl/fHr8+bXA5QWSb dzibAUlUmJnWr1xUkHtuowJyOJetJgSTSZS/PiboEGBhYn5xgTcDG+7AP UHw+aGbbeL0tOOp9QFezsOKyS1W7vfxIUnSy3WxrqvxaTQnrNtQ7BRPoT 8voZ2L8cYNeDuK8kEYjrc5mehgw9VRPafXq87mSsytandort4lj2ecDr+ uWHR2ZP0Hu+/hzNsJjUcfgTErymVRcrEBt8P8muob9Rp4eUQwQAuqJnmv A==; X-IronPort-AV: E=McAfee;i="6500,9779,10637"; a="314438160" X-IronPort-AV: E=Sophos;i="5.98,228,1673942400"; d="scan'208";a="314438160" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2023 08:54:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10637"; a="625014743" X-IronPort-AV: E=Sophos;i="5.98,228,1673942400"; d="scan'208";a="625014743" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.24.100.114]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2023 08:54:01 -0800 Date: Thu, 2 Mar 2023 08:57:51 -0800 From: Jacob Pan To: "Tian, Kevin" Cc: LKML , "iommu@lists.linux.dev" , Jason Gunthorpe , Lu Baolu , Joerg Roedel , "Jean-Philippe Brucker" , "Hansen, Dave" , Thomas Gleixner , X86 Kernel , "bp@alien8.de" , "H. Peter Anvin" , "Peter Zijlstra" , "corbet@lwn.net" , "vkoul@kernel.org" , "dmaengine@vger.kernel.org" , "linux-doc@vger.kernel.org" , Robin Murphy , Will Deacon , "David Woodhouse" , "Raj, Ashok" , "Liu, Yi L" , "Yu, Fenghua" , "Jiang, Dave" , Kirill Shutemov , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v4 3/6] iommu/sva: Stop using ioasid_set for SVA Message-ID: <20230302085751.1e7f02bd@jacob-builder> In-Reply-To: References: <20230301235646.2692846-1-jacob.jun.pan@linux.intel.com> <20230301235646.2692846-4-jacob.jun.pan@linux.intel.com> Organization: OTC X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kevin, On Thu, 2 Mar 2023 08:58:21 +0000, "Tian, Kevin" wrote: > > From: Jacob Pan > > Sent: Thursday, March 2, 2023 7:57 AM > > > > > > - if (min == INVALID_IOASID || max == INVALID_IOASID || > > + if (min == IOMMU_PASID_INVALID || max == > > IOMMU_PASID_INVALID || > > min == 0 || max < min) > > return -EINVAL; > > > > if (!pasid_valid(min) || !pasid_valid(max) || ...) > will do > with that, > > Reviewed-by: Kevin Tian > Thanks, Jacob