Date:   Thu, 2 Mar 2023 23:30:17 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     Cai Huoqing <cai.huoqing@linux.dev>,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Vinod Koul <vkoul@kernel.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
        linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 3/4] dmaengine: dw-edma: Add support for native HDMA
Message-ID: <20230302203017.jdqsfu5iauw2pp22@mobilestation>
References: <20230221034656.14476-1-cai.huoqing@linux.dev>
 <20230221034656.14476-4-cai.huoqing@linux.dev>
 <b108f61d-e812-a500-0c8f-4fb1acd44ca2@metafoo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b108f61d-e812-a500-0c8f-4fb1acd44ca2@metafoo.de>
Precedence: bulk

Hi Lars

On Thu, Mar 02, 2023 at 09:26:51AM -0800, Lars-Peter Clausen wrote:
> On 2/20/23 19:46, Cai Huoqing wrote:
> > +void dw_hdma_v0_core_register(struct dw_edma *dw)
> > +{
> > +	dw->core = &dw_hdma_v0_core;
> > +}
> 
> Where is dw_hdma_v0_core_register() called?

Indeed. Good catch! The respective change has been missing since v2:
@@ -952,7 +953,10 @@ int dw_edma_probe(struct dw_edma_chip *chip)
 
 	dw->chip = chip;
 
-	dw_edma_v0_core_register(dw);
+	if (dw->chip->mf == EDMA_MF_HDMA_NATIVE)
+		dw_hdma_v0_core_register(dw);
+	else
+		dw_edma_v0_core_register(dw);

@Cai, please fix that.

-Serge(y)

> 
>