Message-ID: <27bcb12e-453c-449e-e4f9-93ac7a3dcaa2@oracle.com>
Date:   Fri, 3 Mar 2023 07:32:00 +1100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH 1/3] kernfs: Introduce separate rwsem to protect inode
 attributes.
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>
Cc:     tj@kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        joe.jin@oracle.com
References: <20230302043203.1695051-1-imran.f.khan@oracle.com>
 <20230302043203.1695051-2-imran.f.khan@oracle.com>
 <ZADLTO0NM1yb5ZLF@casper.infradead.org>
From:   Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <ZADLTO0NM1yb5ZLF@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTZ0enJZdk9jMEs0TTlua0JRYk1VbXJoS2dqR1c4M3ZCWWxyZzdPNHM2UkRq?=
 =?utf-8?B?ZDZLaWdsZVVyRFk5eWZRSTkwb3hjOUgxSHg1eW85YnVKU1FhNHJUQW5FNnhv?=
 =?utf-8?B?c2xVTWpVQVBYQTZCUGZVQ0J6STBvUEF6OU53UGZKZ2wxeGF0UTNCd1ZJbUNs?=
 =?utf-8?B?SHBKVmJSZVE2ZHpTeHJwYlhjcGM4YWpYM2VxVmZrRjMrb0xpclY4SEFPTGJm?=
 =?utf-8?B?aC8yQSs3VWdudzgzU3RzcE9uMlhmb05iUVlJZ05UaUJYSGJGZFc5TlhzQ2JC?=
 =?utf-8?B?KzMwVEtGeHkwN1JoWDNISUZLdEFjOVREQzVtZXlINzNJKzR2SmIrUXJNeURh?=
 =?utf-8?B?bm4wR2ZzVm4rd1UxMlpObDltbFVtWVRkVHRUcXBISjdxcSsvdnVDZHdJYTF1?=
 =?utf-8?B?bWtTMlJ6YmovUjRiTkkyNUpzcEVUV0EvZ2s2NGJyV3FBa1hSbm40V2E3bC92?=
 =?utf-8?B?WmxjcjZXcTVtVDFYOFdFME5EYkFXajhoeGw4WHUvUUFoK2o2WUY3TTZVWDlL?=
 =?utf-8?B?aElTRGxuWlhSK0xGNERrS0pEdnNRUjlxYmhxR1pBaFhwY0VEZFFKUUtaNUty?=
 =?utf-8?B?ekI0aWIvZ3JGMlhPbUg4cEZHT3RjS3FaUGRKL0FZc2o4UVUvZy9MS0lzNWNp?=
 =?utf-8?B?UEd6aVV3a1c1QnB6Yk1DSlNjK2FIUE91ZDE5dEo3Vm0wUCtJRHAxTzh1RzY2?=
 =?utf-8?B?ZjVyeDVFSWZmSm95NTBTR3dJUE1IeGhCUUYzQldPOExPVXZsdTNHeDRNLzVn?=
 =?utf-8?B?dXhzbVk4SkorWW94cUVuUk9DWVl6cWQ2Mm16cmM2alBnL3ByMW13dVgySmlQ?=
 =?utf-8?B?NXpHOWxUSDZPMTByMk5Ea05UOXM0V1ZBY2Q5ZThEUlg1ejFvbVVnR01TYU95?=
 =?utf-8?B?SXNsNzJjTUpxTDFRM0pxc0V2VS9FaGxaYkR6elRQU1NLQUMzcHFPWXRoemls?=
 =?utf-8?B?cFN3K3Z5bCtzMENUekZkWEhEUFYxNDVyZ1RYVDNnS1BuVExqWnViaWhkWTBo?=
 =?utf-8?B?aGx6bEZOdDA0Wm5PbW51aTRkNURHdnIwMDI2TWtRakVGcEdBOUtEUHF6aTQ3?=
 =?utf-8?B?VDJCaDR6dHYrdnYycVoyVWNoTG1LMGlrQms2MzBGazZxTnJmQ1A5cTNRZk1i?=
 =?utf-8?B?b3JPUElxTldYY2sxQThINTc1bVJhd3VKMWUrY3dSQXFzUElHdmN4Y0VpNjMr?=
 =?utf-8?B?N3U5allkRUlGUFNvblhqU3VrZTFLZ0liOUV5NVc0NWxnV0QzbGR1T091N2NM?=
 =?utf-8?B?d1FYVUNqN0trVzc4aGhlMk15MVZyQmRML2Q4Z1FvYkMvY3R0Sjh1aXhsN21X?=
 =?utf-8?B?WFhOR29JakZFZWxHUmhXM2p3RkFYZVRXM2lQcWZ4QXU5NTUvRm4xSG14N2tq?=
 =?utf-8?B?d05ka3NXSWNwU0NkeEdiMkNITjJmaTBpRDVYaVNsL0dScGRvUm0xMEhNK3cw?=
 =?utf-8?B?WGIwRzEvWjhlaWFmdHpHWi9BTnVWMXp2N3I1dlIzb2tvdndiS3hIajNQQ3p3?=
 =?utf-8?B?MmNUMENDOERhUDdzV2ZmdUhjdHhMNGlrbytUd0tNenhOV0w3ZENxM3JuaFFx?=
 =?utf-8?B?dHgzeWdGdFduRXFIdGhwTlhQTEFwMEYyWHBocWgyKzFYZDI2Y0lmb2NxZlZE?=
 =?utf-8?B?MWdlVnFvQytUSjFBV0lsL3IzY21MZ2YxbEsvOU9wbWd4YTNYQWsvaVlKN2Qv?=
 =?utf-8?B?RWQ4dzFzUzJwT0RSRWh2dEJYVjdKVXhyTEZWRVNzWFh2ZXhXaHZHNUFrQVJa?=
 =?utf-8?B?cTF2TjVtQlBWTDY3Qkg1UUd3RUNqeHpsVERYM3JMemwvS0wzaFpSU21pK3Rq?=
 =?utf-8?B?VFpxYUZ5c2dwaWhuYm9BenlJNHkxTFpwMld5ZDY0NTViZklLZXduN0o3UUNY?=
 =?utf-8?B?UnNlL2IzVXoxVFQvOCs2bC9RSFVjSG1FaTNJSFFudEhBcHgwMG5kOXZCV3Nl?=
 =?utf-8?B?ck5mNllIby9JdjQ2RlVoRWhBNko1b3BtV1pUZm5wMkdHWDFpc2U1UTJKdS9p?=
 =?utf-8?B?cE1MQ2lyWVNKanhKeHk0Mnh5Rkkwd2tXYzNYVkdlWno3dWFDZ2hlckVWTVZJ?=
 =?utf-8?B?SFZ0SEdNcWZIQ2NzNk53UmlrY3JQTUNnYUg4NkJlQXd3ZEhtK05iczlYNlQx?=
 =?utf-8?B?YUdYL1hCY0tLYm1oOS9iYUNiZGtzWEp1VWpIMjhYcnJQZUIxVG92TjN5Umkv?=
 =?utf-8?B?QkE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: jC2jt2g0MXjlQMytWfbjX0ktA0eXpu6MFHQSxgOMiBk2nstW/btYvg0jNv2Y9L45QZaFGVwN8+47AMzaDBwVeISh04kw+DxVzSg50vBGqtCqW1PFGGRUGmY7c1VWL7DU06OG7uASoNMpMc8+AMIT+9+qXRDhK7gqvPj62rUVY3v+9yUk/V7W+dVEJl8VWTaaOtcfRVx4wPpidX2mUtuaKniL/32WAHO6TwaDw8c2zQoF8oWpM7DOu3GLz7/3iTTXVq67nh5bj72QF6mGh6tU8F+sCyE2/qoGsO7y7zLiEmJbsXUnSsp6q29eLMBOuNRDdVPKeFUgrHG2NageJsQMumAciXTmcTPFgs2ME+q87ZgPu3NJV6blZjy5MTmqALD2ukd2Tp9VlT5Tqwec6g5VLyDoozfKY8T5jB7v3KNjYHAXNTsM5/ICVdNb1DnR8oLc/3vFXWLCZSxsyN51aBn3EIMpMwkBIMeNzrpgRinh8wekw+D7+PqiRmJOJxX/2/da3K9AjncX1NWi4A63dMsAGpcpE2M/jbxlBx5W5S+6y7elHZ7tF+x3a8yrTPDYFy23G1xhsi2/SC2VvTkEp2vJLhkkFnmdi33eVgWlDx8SUnQKS0BUJU3OT+c/3+lSI1wCaNv2Gz7/nq3Bi+BvDiKL7nqVOaVkFOFgMEMRKp304fT9ouqgUBjk6fxQptCQ11ETpCYS7qHM1Gur3GLjGVS88CuqgTWZTNs3OWRVb/IgbOrnhLFmmC6g8mXTtrXxUjVmGGJLWaEli2zNvO/enDuuKtJRDGKzyQsu9RaWRuvp05a7x3FOkbMg8PfzRXRi4u0xEsOqewN8/ls1x+4vYTEYbkJ+7P4/WQ0sp9RT2wdf7E0NlsrAjFDHfi844dAwKoePTAIGpuIbBzZCFs1jUgSCKc8U3cbIb0Y/g3PBjpESK2Y=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3837a512-9f8f-4249-9670-08db1b5d31d7
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 20:32:08.9708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k2LRH4BWhZl6O92vDVqDhoXxPAE7UrUNhh4euqTHPa7k9ya0z6r5xQ2eVWhAhJQwxdeGVdil5eznwlDJxN6xbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6484
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-02_13,2023-03-02_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=792
 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2303020177
X-Proofpoint-GUID: qz8ir8SCR1xXP09e_pFGrUFp6uYriR-i
X-Proofpoint-ORIG-GUID: qz8ir8SCR1xXP09e_pFGrUFp6uYriR-i
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Matthew,
Thanks for reviewing this,

On 3/3/2023 3:14 am, Matthew Wilcox wrote:
> On Thu, Mar 02, 2023 at 03:32:01PM +1100, Imran Khan wrote:
>> +++ b/fs/kernfs/kernfs-internal.h
>> @@ -47,6 +47,7 @@ struct kernfs_root {
>>  
>>  	wait_queue_head_t	deactivate_waitq;
>>  	struct rw_semaphore	kernfs_rwsem;
>> +	struct rw_semaphore	kernfs_iattr_rwsem;
>>  };
>>  
>>  /* +1 to avoid triggering overflow warning when negating it */
> 
> Can you explain why we want one iattr rwsem per kernfs_root instead of
> one rwsem per kernfs_node?

Having an iattr rwsem per kernfs_node would increase memory usage due to
kobjects. I had tried per kernfs_node approach for a couple of other global
locks earlier [1], but that approach was not encouraged because it would impact
ability to use sysfs on low memory (especially 32 bit) systems. This was the
reason for keeping iattr rwsem in kernfs_root.

Thanks,
Imran

[1]: https://lore.kernel.org/all/YdLH6qQNxa11YmRO@kroah.com/