MIME-Version: 1.0
References: <ZACvxNOuuyifQ9Nx@kernel.org> <37578649-c696-f3b5-a216-196e210929e5@gmail.com>
In-Reply-To: <37578649-c696-f3b5-a216-196e210929e5@gmail.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Thu, 2 Mar 2023 22:02:54 +0100
Message-ID: <CANiq72=nvg3cU61zRYXxLUKvEib1qezRHGZSC=7sGah8aDH-dw@mail.gmail.com>
Subject: Re: [PATCH 1/1] rust: bindgen: Add `alt_instr` as opaque type
To:     Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Derek Barbosa <debarbos@redhat.com>,
        rust-for-linux@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 2, 2023 at 3:59=E2=80=AFPM Martin Rodriguez Reboredo
<yakoyoku@gmail.com> wrote:
>
> Still, we have to be careful if these kind of things appear in
> the future.

Not entirely sure what you mean -- do you mean if some Rust
abstractions used its fields? But if we were in that case, it would
not compile, so we would notice. Or what do you mean?

> And I notice that You haven't mentioned the version of Bindgen that
> You've used, including its linked libclang too. Otherwise I think this
> could be accepted.

I could reproduce this with the expected versions. Since, for now,
those are the only ones supported and the build system emits a warning
otherwise, I think it is fair to assume those versions were used
unless otherwise stated.

Cheers,
Miguel