From:   Song Liu <songliubraving@meta.com>
To:     Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
CC:     Song Liu <songliubraving@meta.com>, Song Liu <song@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Kernel Team <kernel-team@meta.com>
Subject: Re: [PATCH] perf: fix perf_event_context->time
Thread-Topic: [PATCH] perf: fix perf_event_context->time
Thread-Index: AQHZS6nzbIJnibMzeEap6dRInzeNaK7mg0cAgAANEICAAXCkAIAARLQA
Date:   Fri, 3 Mar 2023 01:21:51 +0000
Message-ID: <CEA56FAA-01F1-4FDB-8956-2311DD0CBCB3@fb.com>
References: <20230228192145.2120675-1-song@kernel.org>
 <CAM9d7chLaXDU4mMkD1U6YuOGZXcu7PFWGOuEkFKSkbrCLS+zWg@mail.gmail.com>
 <BBB1A458-25CA-4C0F-AF04-18534D092142@fb.com>
 <CAM9d7chCcz=o+XX_ruZ3+zfp2Z2sPDG43dpTZH_mf6zXYjTJ7w@mail.gmail.com>
In-Reply-To: <CAM9d7chCcz=o+XX_ruZ3+zfp2Z2sPDG43dpTZH_mf6zXYjTJ7w@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C+9BL9hdIGrUaYQ1remvkvjYPCy5+a4ePOWvl6A/bJ5d0IDhgIOQyRnEjL5M?=
 =?us-ascii?Q?HAQPkuVEhBf+nxsT8wieJ8U0hcpJIfPEL8RNtk82GWsk2fWNMGVFFPvYqQzl?=
 =?us-ascii?Q?qs5ctgbUS5UeeCvXdtwGx5Rdx7CYUt42oPGXbfSpUaT2RsKmv6BHomdgduwj?=
 =?us-ascii?Q?8kPN2iHyqDU82RXEyVQX8RBCznxfQRxGBj3AgvtNTYB36Dj2uLp3oaxPb/f+?=
 =?us-ascii?Q?k3C5oSOqwnCQta697UFcAbOzFulaRTGHYtqqpnonSk2D+vfbH9sl8CsMXp4A?=
 =?us-ascii?Q?sgrujWShph2/hbqeQqsQmf8rq/k4KsXSEhMSkzKiQfvk4ZmeKUJOymrSXCLc?=
 =?us-ascii?Q?WDwSMtcGoKluTdSIFreLDh4kXIqMwh9Cwmzeg6SxgonfRrUxf8UYzyjwbJYP?=
 =?us-ascii?Q?lw7S83BXioIKmxM/KplKqxcJ22dAOEebL6/UDtA1XRc3a1GJ7G0Vem4fD1im?=
 =?us-ascii?Q?PQaUUhg3Er9IF4zuISO2bkdsM3uJGKyGUGgbCqJDyAYzuKwXAPx8qYFccYOq?=
 =?us-ascii?Q?cFm0PGP9s2eo8fZu1BkW5f1pAL0HcgjK86YN/iLOEnf0VpHsOWsQTBCU42JQ?=
 =?us-ascii?Q?XXt84B3VWgafMUFeKHbLzksBjArBNTnNFQHa1bMYzxNRF8QGhoz5HHLzFgTT?=
 =?us-ascii?Q?iHLpPv9Pd1pEQini7ibZefJeUwotc4Zhk6TW77JdLYZZSwWOUHgk+a9A2LMJ?=
 =?us-ascii?Q?AwYxyccFGV/PxERiVC0sCElJybnaaZVJBapKdA0pTfwnStasVOnt6hyKvcU0?=
 =?us-ascii?Q?Rqga3kbPW8NSZ5NUmf6OklwhzWZ8Oy8o9WPS5GGrLcFkDLX6sSrn2N70QD31?=
 =?us-ascii?Q?vZ5oFKruYiv7//40Vqb7GKfvJxISFefpnf3Qkch0JzfSfYBLda+QYbpNwNE/?=
 =?us-ascii?Q?Zc75qtnSjQOcQCqbaEj3aA46g3CPS2JqZboUQv93N4neVYN3KrnP55tlIjC1?=
 =?us-ascii?Q?c5EJjI6GzlHMHJ6/ppfZT7uhdCjoRnjU6vOp97gV9DPnBwUk39lQ/xBsMOwn?=
 =?us-ascii?Q?juJprvUxDK9ej5m5JQ5fi2lQ1NM6DKEe6lSht3E8+VdRmQ58ENerKeBQtB7R?=
 =?us-ascii?Q?50mmRr8mqvQ3LKXli0c84t78T2zgUFmEACHoq2E9QDi7XnfJ60rKyfx0YKo2?=
 =?us-ascii?Q?7iybv/dMiVN4ngHFEYo0N9Q5XGroJyMSfPTPqBj+tQHUZn/KHpjvRKOKp1GF?=
 =?us-ascii?Q?9ykdLjYlolR7b2Oxthbmq5ky/T8hoRreh6BjkEqr1+RapU8cYgmimCDm2ZxS?=
 =?us-ascii?Q?eGjO3Qb5c55Fo1DpLd6GezoEu/1s93KWydoAJjgYh5EpYbY5+LDCoOOXK/V6?=
 =?us-ascii?Q?SN19BoGnf3wFN+0QVYGl+iJqsh+PcXmZ+zZ/IBBXkQ7WuMp/sBjDdNTEGVrj?=
 =?us-ascii?Q?RYU1E6LwlXOosmWFv2CamkP4ZZXNXbFlKr0V4w4JxAc0gQXrXg16dvia5Tzn?=
 =?us-ascii?Q?jeB3mSz8gxcTUQ0ByNj9h+UXDGOFnk1/rDu4f420+t4pqnF2zt8TuYC+umbm?=
 =?us-ascii?Q?PPv6Kh7LHQyxfEYKgA7aK7JPS093Yf0xFyQpGz5qL/gy9hwvnKVESV/Vlbie?=
 =?us-ascii?Q?Oxfhzen7YF0XvF17rHiZ45VFAxNbeThUflZY6a23DJmsUCsXj8VZii67dyeG?=
 =?us-ascii?Q?jR74aCFrPm/Ar5XB1UQL8zxcS9RWkHKjL0PvJoU2Jl3S?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18C77FC8537E1F4EB7955179B2B3CB76@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57a4c2ee-ce5c-4292-049b-08db1b85aaaf
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2023 01:21:51.0942
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kwLzvrjtWDLGWZwyRofKiMz5Hs2RMublYjfNEUnKY/oGEljXdJ++OJHIxbrkmrPaCrbGZNOk78sgLVQarcILPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR15MB5584
X-Proofpoint-ORIG-GUID: TyorruJR7Jd6hyiFOUiVlm_nlM3rmaiZ
X-Proofpoint-GUID: TyorruJR7Jd6hyiFOUiVlm_nlM3rmaiZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-02_16,2023-03-02_02,2023-02-09_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mar 2, 2023, at 1:15 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> 
> On Wed, Mar 1, 2023 at 3:16 PM Song Liu <songliubraving@meta.com> wrote:
>> 
>> 
>> 
>>> On Mar 1, 2023, at 2:29 PM, Namhyung Kim <namhyung@kernel.org> wrote:
>>> 
>>> Hi Song,
>>> 
>>> On Tue, Feb 28, 2023 at 11:22 AM Song Liu <song@kernel.org> wrote:
>>>> 
>>>> Time readers rely on perf_event_context->[time|timestamp|timeoffset] to get
>>>> accurate time_enabled and time_running for an event. The difference between
>>>> ctx->timestamp and ctx->time is the among of time when the context is not
>>>> enabled. For cpuctx.ctx, time and timestamp should stay the same, however,
>>> 
>>> I'm not sure if it's correct.  The timestamp can go when the context is disabled
>>> for example, in ctx_resched() even if the NMI watchdog is enabled, right?
>> 
>> I think we do not disable EVENT_TIME for per cpu ctx?
> 
> I can see ctx_sched_out(ctx, EVENT_TIME) in some places.
> Also it'd reset EVENT_TIME if both _PINNED and _FLEXIBLE is
> cleared.

Yeah, you are right. I missed this part. 

Hi Peter, 

Does this fix look good do you?

Thanks,
Song