From:   "Liam R. Howlett" <Liam.Howlett@oracle.com>
To:     maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Snild Dolkow <snild@sony.com>
Cc:     "Liam R. Howlett" <Liam.Howlett@oracle.com>, Stable@vger.kernel.org
Subject: [PATCH 2/2] test_maple_tree: Add more testing for mas_empty_area()
Date:   Thu,  2 Mar 2023 21:15:40 -0500
Message-Id: <20230303021540.1056603-2-Liam.Howlett@oracle.com>
In-Reply-To: <20230303021540.1056603-1-Liam.Howlett@oracle.com>
References: <20230303021540.1056603-1-Liam.Howlett@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R3AK+ul/yQd6bTK3a2fsgyyIoT24L80OY1cwHt0TliMxp5QarFe4e6X0tLOo?=
 =?us-ascii?Q?XZCx01/DFem2dhne5eRPeHhsFp/CcOVfzr5SwlRnsjUYrZ5UZE4vQ24OP9rI?=
 =?us-ascii?Q?YRLPQbqyhr1FfrOj1xKV0iYI8yYdqMBgHEX559qXPStNsrfyLhZbMYDP9+Bu?=
 =?us-ascii?Q?RdhFQPdYnyxAfxhe7kTEAq1nWC5+2Gw2aBUUwrf26Siv9JTiC4wk+YyDQ3c4?=
 =?us-ascii?Q?/fa5Z3C+Svgj6j9Zk6c5ZHSn+xTDdUeu+kY5qudIGsKs6r+36auGSD4cT8+h?=
 =?us-ascii?Q?AJ3R1LPR5lDmO/Ut0fJzfS01uba4HtIyn3XvuyIVFw6/dOHdEB21/aaBYvcu?=
 =?us-ascii?Q?EnQDxMNgZO6vcfs4DqYniDm0tVCAY4tncQL48vCZCG02dDlWnuW6TMW/xB1N?=
 =?us-ascii?Q?w3ogaWVKeQYsCPq6aH6eyUgTygm09QiZjqbz6kKABqzl8xx27MvqJnGqtbqa?=
 =?us-ascii?Q?BelaLmQp3vzg9zKkOB6m7P85u8zoIoJkD/2extjtwYaFix5lwAeYiPzf1/dc?=
 =?us-ascii?Q?K+AuHhDHBVBCR1sjMX/5XyT50+AQujI3ge+fgwPto/cU4pVXPrQCRwYZVwBU?=
 =?us-ascii?Q?t8xAfu94wzBVQ7w05PrpUxQIERZy2cpYXjUkvAY+mF8xyf3NCxwvQwYNL4KK?=
 =?us-ascii?Q?8IJTIuF0ZvcnrlzG5PKm0eoB4VEiBNlWl3HtBq8idiq5zPLOSsNev0OEuXsb?=
 =?us-ascii?Q?/rL3/rEIB4LucXF3OjY3E0s1zub9YPbfUWEjA2WsaINNNgtHfgglDex0JQjB?=
 =?us-ascii?Q?ZGdM5jKfjmlwXdjR6w3uGFxiWaI32BgJgEiH1WskFzFhl74OzZWakI4Kf1K0?=
 =?us-ascii?Q?1CxixBX2lYVnlW3hl8pMoWJten1qGGLesR9rx4oDdnxQCePotQA3+U9hihxl?=
 =?us-ascii?Q?/VlyzbdxvdsMnvorWyWJJnfw1z39LZj6TlumEC8/7ZE2i/9jDaB0Y1mIkltN?=
 =?us-ascii?Q?fVGVn1msMSp2lqbJavgDEOSrI3GYKV+DS9cpCgZ+ay3mjPcldKp0gHmyT5/0?=
 =?us-ascii?Q?jbYXP67oV82LIXwRxEwFNXmUvGaPVe/ct+dojHkkuT+TeJRfZDb/khRHx3iF?=
 =?us-ascii?Q?N61S+orcZ02FkrtNlxWPzYjL2iWE62qmkeKC70o0L6rnKioPN0mKJciFGIgq?=
 =?us-ascii?Q?30xAZUDUF+WbYlP7lJrAOYBG/R7Wt2mETEgkhNQaAwWW0CR93ErMQfhI2L3a?=
 =?us-ascii?Q?vY6IWQh4R0GjGbdNlZ+Fixo1KXNrJlCCL1xNYxR4tOmSL/MaJdc8g7WbD8WH?=
 =?us-ascii?Q?q7qbXSpGN9OuY2S66ahhFfMmxJGQQibta0fHAVV0IzvR9/nUD5jUWTYUBJG7?=
 =?us-ascii?Q?Yq7iAlO8aoH8uPUagRAb2cFNqtzHLRZoWajmjwyeuse9aLzWOUkg6LYUCy4o?=
 =?us-ascii?Q?GO+AwkVEDEY6Y6HHhYauqKI2I5XUcG84g1m/M7yri4tbk3qF5QA1jOy2dlAv?=
 =?us-ascii?Q?ND2qE3xYxAFM7YbojgBPLur5AaXhRR2S3qGsHhjvpxVqsZTDQHaRhdQ9eFoq?=
 =?us-ascii?Q?morydBO5R7Wzsm+hEec76BBkm3+8HekC/8+nS+CYJfp1rL65FLK0jKnBf2P6?=
 =?us-ascii?Q?bRdYqvsKkQF8LPuZrgiLMoXnFLSb9raJt9JjM1l2w8/VxFcnz19xrZU6fD19?=
 =?us-ascii?Q?Dw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: f6+hOowneqfxFk0yt7Ax0Gk4QlrwoWsMl81eV7q2wcI/jcmk8DeJKVSergKdgCAJZhJkTuD89dy8NIS95mQ8pnTJ/lYzS4V77oJxtKrwGqygFJg4RRGHGUNkybNer2sJilIkdmQR9z/uTa6Xh0Ee4s4T1yRBbRPApXvheJ3p4E8STi26S0gAIX0Bpy1eZtwpLhOMQQcufhB8l4Xq8INOyE+p+Kc4gUeY7P5v1+y3vjN+Yb9hlKrugf6f0yP5fF4h8CSntoRHpFx730xXrp8rbtsYyksovj7CXMW+f1D6q7L8QDeZ0GD9n4c+Blp4bEEjMTFcDTmPijRBUykSIr6Ge2hPRBU0CcrEcYx9a9JZEFm+EzNiXVT0E03RBC/dzDbTknpKDUOvpnoFP34PB+pheDDOMrApmkTTds04KtLiGfNd3QnJ6o/rP0trb3rVC6MaTzSwsuOm3ERYp5mkTjI9L5ygmE1Ih+LFFVuvUs361NeFxVtS9VQLtNVqFpX9EMv9Lihv+YXqNZAa99JtsbJfRB+CtYOAAJNkG3KCFncu7CWA9Aro4qT9NHHT42clhalwOv4OYam5ZzgV9lsOLrAJg57SOeDSrJIURr+HIsu06RDD/h4jORmUAaBmVhLW0x2DyGP3uSZmoB13Tfv6bF4aJ/5qgn/7BwwPV1EsAaS92CkjxuwmNe2jm07FZtXKAzWoieHDsW5mXM1Mg4WpXkYjIeekqCjHTwHauLG5ZEa9i14oPT8ztoFZXsOVHhHh0T+PVHJTqtNrTJBxyFN5Q+f9EdZNHVQWkl8Y8ybw+0Cunj2QBIJDXy6SJCTEl4xS/Fgt5QGkDETgYfk4XogVQwJq8u0zCILMp3l7/CNKxSS+ccSikhyrf6ph8y1sBvR4bmcFGoVdMEjgbT4wtVdYb1ZYUKbTSYbewqj4RXjk58PSXw8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e789990-27db-47c8-773b-08db1b8d37da
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 02:15:54.5397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KTu/KX5njyyewCbTtfR0rbH6bqGxU3L8M8zCtIDMMprDe7600KzOdbCU6PeFnogOUatTWNvMDXEMsUygzOWVWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4770
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-03_01,2023-03-02_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2303030017
X-Proofpoint-ORIG-GUID: M2nNT_23kXJX-GSQGIiLO5WxsCjGHYDh
X-Proofpoint-GUID: M2nNT_23kXJX-GSQGIiLO5WxsCjGHYDh
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Test robust filling of an entire area of the tree, then test one beyond.
This is to test the walking back up the tree at the end of nodes and
error condition.

Test inspired by the reproducer code provided by Snild Dolkow.

Cc: Snild Dolkow <snild@sony.com>
Link: https://lore.kernel.org/linux-mm/cb8dc31a-fef2-1d09-f133-e9f7b9f9e77a@sony.com/
Cc: <Stable@vger.kernel.org>
Fixes: e15e06a83923 ("lib/test_maple_tree: add testing for maple tree")
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 lib/test_maple_tree.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
index 3d19b1f78d71..fa86874763f0 100644
--- a/lib/test_maple_tree.c
+++ b/lib/test_maple_tree.c
@@ -2670,6 +2670,36 @@ static noinline void check_empty_area_window(struct maple_tree *mt)
 	rcu_read_unlock();
 }
 
+static noinline void check_empty_area_fill(struct maple_tree *mt)
+{
+	int loop, shift;
+	unsigned long max = 0x25D78000;
+	unsigned long size;
+	MA_STATE(mas, mt, 0, 0);
+
+	mt_set_non_kernel(99999);
+	for (shift = 12; shift <= 16; shift++) {
+		loop = 5000;
+		size = 1 << shift;
+		while (loop--) {
+			mas_lock(&mas);
+			MT_BUG_ON(mt, mas_empty_area(&mas, 0, max, size) != 0);
+			MT_BUG_ON(mt, mas.last != mas.index + size - 1);
+			mas_store_gfp(&mas, &check_empty_area_fill, GFP_KERNEL);
+			mas_unlock(&mas);
+			mas_reset(&mas);
+		}
+	}
+
+	/* No space left. */
+	size = 0x1000;
+	rcu_read_lock();
+	MT_BUG_ON(mt, mas_empty_area(&mas, 0, max, size) != -EBUSY);
+	rcu_read_unlock();
+
+	mt_set_non_kernel(0);
+}
+
 static DEFINE_MTREE(tree);
 static int maple_tree_seed(void)
 {
@@ -2926,6 +2956,11 @@ static int maple_tree_seed(void)
 	check_empty_area_window(&tree);
 	mtree_destroy(&tree);
 
+	mt_init_flags(&tree, MT_FLAGS_ALLOC_RANGE);
+	check_empty_area_fill(&tree);
+	mtree_destroy(&tree);
+
+
 #if defined(BENCH)
 skip:
 #endif
-- 
2.39.2