Message-ID: <2075986d-2344-80ff-d494-8bdc97b627d5@amd.com>
Date:   Fri, 3 Mar 2023 11:25:13 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 2/2] perf test: Add selftest to test IBS invocation via
 core pmu events
Content-Language: en-US
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     peterz@infradead.org, eranian@google.com, acme@kernel.org,
        mark.rutland@arm.com, jolsa@kernel.org, irogers@google.com,
        bp@alien8.de, x86@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, sandipan.das@amd.com,
        ananth.narayan@amd.com, santosh.shukla@amd.com,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230302092109.367-1-ravi.bangoria@amd.com>
 <20230302092109.367-3-ravi.bangoria@amd.com>
 <CAM9d7chQA27aD_mPe=3-9jZLWP_a64ztihuK=upgNL++kMFSNw@mail.gmail.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CAM9d7chQA27aD_mPe=3-9jZLWP_a64ztihuK=upgNL++kMFSNw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWZCS1JnNDdFcWFnbk0xTTk4dnRlNjVuWnBsa0pWNXNTTU9lR2FUajlDdE1Z?=
 =?utf-8?B?bUpoclNTenJDcERySlVSS3VaOGgzVUVCZ3N3TzFPbkZsYUhuVzhVVktzb0Iz?=
 =?utf-8?B?eHBSK0JmNURCSkVxcWc2T21RV1gzZWhOaDBna2VGVU1JdVJtOWl5dmYxRUlX?=
 =?utf-8?B?dG1hL0wvb3BvVDFqS0J4MkQrYUQvYWNrNEdtWjdpdUpzRUVvRThzVTJOVWYw?=
 =?utf-8?B?UWQweHd5Y1ZMQmpIazdhcmhEbE1KcTN5YUM4bnlFYXAzQWZIdTBmNmQ2ZE4z?=
 =?utf-8?B?U1dEUDBjNi9LdW9mbXJyL0cyVGVyZ1EvaUNwNVM5d0xDSldnWElPam1MNjEw?=
 =?utf-8?B?d28zKzI2Ty9wTGNicW5NR1NMOU9wSVU1V0FOODFPLzZjdC94Wk1Zd2JhVkVs?=
 =?utf-8?B?aGVaNUZEM2dLRU1CR3l0MmE1b3BhaFZLVkZJWjUrZldSNS85V3lFVGJ3Z3R6?=
 =?utf-8?B?MTRJT2dFK3crT2crQWYxd1dWUnIwdXdaOHNOSUFBaUNVRzE0YTJ1MlFDQS92?=
 =?utf-8?B?ajZMdnFHUGFveWFCZFpKc3piQkhna0w1clZra0FZRWk1UXY0YnM1TTJSclJ2?=
 =?utf-8?B?ckl1ZmI0MWlaSGFsNFdFd09YeVM4YUJYYXFmTGJhUUVPbHNKaGhzYzlHVzZq?=
 =?utf-8?B?eW1LbHo4bGY5VUxWckludFloZDh0cDVVNUt2RGhEaHM0RjZ1SVFQdEtMdmRr?=
 =?utf-8?B?VHk5eDdrS1BTSjE1cEZHOEx2VjhJL2VqWk85MGlzWXNyeGVrU1IxR3RWdXND?=
 =?utf-8?B?bDJpSnhCUFBIVFJaMDdwZU9mZTdHVDh4QktESXY2Qk5wcWplMVAvWmwrZElL?=
 =?utf-8?B?YXV4Tmhjd2U2MWpFbXczM2gyeDlHUXdRU2pBYnFvcStmTDh5YnNmYmRwT1c4?=
 =?utf-8?B?SUhGbk5ZYjhMeVowRHRGZHgwYlNydVQwdWF5VmJpZU9vQ1pmSDVKa3lWTjMy?=
 =?utf-8?B?UmREQ3NGU2kvM2l1TEZ2Q3QrREwrYVh1NzNpenJKQWlXbFNOOGdoTXZ1YjFy?=
 =?utf-8?B?UnJKKzRqRG0zdkY1NE96b2NXMjU3N2I3QTVQa3lPb3ZnTjZxNTlaN2ZxT0Qx?=
 =?utf-8?B?ZkxmaCtnUldhMFpibEh4d3c1RDdGa1phbVhSWHFzMHFhdm9BT2tQZzAxVW5o?=
 =?utf-8?B?bnd3TWpoaWhLbWpDSDV5aDNBdHFSZk1JV0xRQ0lWRlJkQ0h6eXVadkROTmtY?=
 =?utf-8?B?djdhZjErc3JibndzdEU3V0ZhdU1XR2FIem9XRnpIYllZRVpNc0lPeTdGdkRW?=
 =?utf-8?B?cTVrT3E1SjJGamdFSHJ1R0M2bHlCd2hjVXl0WG9UOERBYXBlaEhkWSs2eDV5?=
 =?utf-8?B?K0l0N0p4ditDY0xOZ1dpekN6R2FpSjkxWFU0TkM1S2tvVVZjUzUyY0pENGlw?=
 =?utf-8?B?WkduYi9XSW82TVgzWGdsaGlsZkVZVUZ2NHlVa09iTHdmeEorRGtRRk9mcnpS?=
 =?utf-8?B?L252Nm5FWUJ2K1FZOFZkQmJTR0hKYUZDQzYzR2VvaVBKdXVucG1oRDdNOWtV?=
 =?utf-8?B?ZXVnZUZnektOdDlyZU9TUWQ4eUI3NWE3N3NOQTJDQUsvRGNZdFg2b2p1VjhE?=
 =?utf-8?B?MnRqQnE2QXQ1cEc1Q28vRWhlSVR4UnhOdm9MNks1RTZDU0ZYK2hua0t3TFoz?=
 =?utf-8?B?dFluUW9LTzZoc2tXT2ZFSVdVaEZWMk1ON0JwQzJ4TS9jYm9wQWVob2ZndVIr?=
 =?utf-8?B?WHZSRzh6Y0NPVG1XSVZGRW5seHBTVVNNOTVRTUY2M1ZlbHZrOHpDVXZxNStP?=
 =?utf-8?B?Zit5U1FCR25URHc3ZXhxSEp4Y0xtajc2QmhVRGM2OFc4ZHRTbWdIdGp0dXNq?=
 =?utf-8?B?Y0ZlemNEeldMc0MxTitDSFgzM3BpMUFaMmZMdCtkMUsybkoxZXkvVmNMb2lQ?=
 =?utf-8?B?OEx6Mzk0ZHpDN2RrSnpKS09DK1lwVnFWQzFmZ2tnV0pYU1NGTFFOSktvSWZH?=
 =?utf-8?B?NzQwUFFxbTZESWJOSzZQYnJ6OElCeGtSV3UzOEp6MW54TzFXblBrcHBVTSt5?=
 =?utf-8?B?SWlteHVLUmtQMWpxY0xoQ2dZZGpTMmdTaElESjVWTkdwVFJYOUtDYmQxYzFL?=
 =?utf-8?B?NVNFWnd2dElMV296c2FIaDNHcHRBb21wVXZWM0c4OGlyYkRNalhwY25FRGo3?=
 =?utf-8?Q?JHjJSk0gAnt+oVugbrc2KkGpX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d3f6850-d39e-415a-0d33-08db1babe328
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 05:55:27.1061
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4JE+mz3SXaNGE+quFi6FoVpxrKzSNagsYKFMGzE74HG1hXg/Ian5oNYN/lnqm3GVa5KHINrzYvGcZHokWZVnIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6932
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Namhyung,

>> +static int test__ibs_via_core_pmu(struct test_suite *text __maybe_unused,
>> +                                 int subtest __maybe_unused)
>> +{
>> +       struct perf_pmu *ibs_pmu;
>> +       int ret = TEST_OK;
>> +       int fd, i;
>> +
>> +       if (list_empty(&pmus))
>> +               perf_pmu__scan(NULL);
>> +
>> +       ibs_pmu = perf_pmu__find("ibs_op");
>> +       if (!ibs_pmu)
>> +               return TEST_SKIP;
>> +
>> +       for (i = 0; i < NR_SUB_TESTS; i++) {
>> +               fd = event_open(sub_tests[i].type, sub_tests[i].config);
>> +               pr_debug("type: 0x%x, config: 0x%lx, fd: %d  -  ", sub_tests[i].type,
>> +                        sub_tests[i].config, fd);
>> +               if ((sub_tests[i].valid && fd == -1) ||
>> +                   (!sub_tests[i].valid && fd > 0)) {
>> +                       pr_debug("Fail\n");
>> +                       ret = TEST_FAIL;
> 
> You need to close(fd) when it's succeeded for invalid one.

Yup. Will fix it.

Thanks,
Ravi