Date:   Fri, 3 Mar 2023 14:05:55 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Guillaume Tucker <guillaume.tucker@collabora.com>
Cc:     Shuah Khan <shuah@kernel.org>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        Doug Smythies <dsmythies@telus.net>,
        "kernel@collabora.com" <kernel@collabora.com>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernelci@lists.linux.dev" <kernelci@lists.linux.dev>
Subject: Re: [PATCH] selftests: amd-pstate: fix TEST_FILES
Message-ID: <ZAGOQznWjSNuhn73@amd.com>
References: <20230204133454.260066-1-guillaume.tucker@collabora.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230204133454.260066-1-guillaume.tucker@collabora.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YbhxI3C51rmaVpSV/rVcrJl2l6tR1IW5W7PqFgzimismn4PsMqKvkmoebqHd?=
 =?us-ascii?Q?z8Jzsi1gK6GzBAHlJYnAg7o+a6NQVrEfNPp9XWvyymQdmG16HTDm09GakGCQ?=
 =?us-ascii?Q?23Rx/jOsXQLD38DB/8xhlXctsMRv/68c1CvsKc0IoeKxeR7R8h9Qz3CzhMun?=
 =?us-ascii?Q?NDXfuIoyuWh3aPTgs5qZh7Rmqk6/yzl1YoW9Jn7CIRmGKcbF4EMbm06uc542?=
 =?us-ascii?Q?JUKanViuDwPnRjtoi/0CarK6rdDraFyTyfLtKfwnR16a+s7Dno3DGxopSgzW?=
 =?us-ascii?Q?gdIeZCC4tO3UP413escJwjStGb5eF2/8lQeJUJ2p+GG8gUHRKsvjRyWfV9Y3?=
 =?us-ascii?Q?gvmUWFFJUEg3y7CKyx1Uw+W8VlnoP4uOZ8l6B6zu+lEAyEJB93gWgAHh32TV?=
 =?us-ascii?Q?zFKAqQJa9rgCTDTgSBRo8V1f30a6ScYkT1TiSEpLaDTAyWdwccvlWpgCKUVj?=
 =?us-ascii?Q?Ho/XWGSaNVPV6NjddT+zFWy55fw8U93w/W4fRtLA49yqzU9AogK5qkg6ecTb?=
 =?us-ascii?Q?N+5bPnK1XeQJgz8wW4vtQGlEFcJionXe48g7xk+PQq5E7tWv8t9lNKWGYyt3?=
 =?us-ascii?Q?IeqSAakJLJV7JW820LZ2ywGy9xxj5OzrgGcUWpBGB6pcqFHiwdkwrxFFrUwt?=
 =?us-ascii?Q?S2K3H5AHGAlmwuuOla4hQGuNfX+hc5GGCywfDxJk/J9H3x9sItqEAY8SFO+O?=
 =?us-ascii?Q?SnoanKr9Orxtou0mEJbDzOA49otgSELKmKD3mdXRwjnfNlLKPBgUdYL50/2R?=
 =?us-ascii?Q?N67YJXJa0BAPl10jO+vhovAbBMGrHFUzNPdCZLcTxhQSwDJciEV+wxSF7KV2?=
 =?us-ascii?Q?k4lAPBO3OcFMwmXfcF9QTQl+v9P7hf7zhqUFkdlQ0c0W8vkk+6RfLbIyFYtW?=
 =?us-ascii?Q?bV0xCw+sjdl1LY295JF/dfkT76hbBUBnClw+hHatRIsKAw1xo16Fe6t1+LX/?=
 =?us-ascii?Q?DxVXFKi+76M7m4/K+DzhjTHI55a8lIDhg8mMUkPMgpjuWD0L2bxrnAC7Krkz?=
 =?us-ascii?Q?+VHCstA1qSDRIF5bIYYHlGQssnrQBvujqDxlXkr7kK31ncJBoA78brVjthsx?=
 =?us-ascii?Q?wrONlUpIcmY3+CyGYMwqRLDDoj9SNMBtoQwErYrwljNAPy5gTV+1bxe9UiUi?=
 =?us-ascii?Q?vBfOZ7ztHFQamDGuqbdNqS+W7FkAs5LNg0RfVxWhw+CPTchzVYq7ChYWMxcG?=
 =?us-ascii?Q?BAdReIsYTrOrpmtkkmkRcGdfAqSye4z5z53ntAu+nPjvYpr5yfvmc9ipB/N3?=
 =?us-ascii?Q?Ld+DvQDohmzi/xTC0p2ojUkGXC8a63rMAzRo1oQNYzfQTHupecsy5Ht/cLT5?=
 =?us-ascii?Q?n37lkXydzxrvlPwrMrhk2eU2Q8/2Y7eiUD/6XYTKf3HUaXgC4Rc4jTXYjJne?=
 =?us-ascii?Q?9cbRcsAQs+T6B9CcpU3ycG1fW+X+q2QOU0ICkCi8dIwMf3fbGpdu7qooN48I?=
 =?us-ascii?Q?5uWOubWqWvVS4o5NCnMgIn7dY9j9G5A0+Tg17+GFVlVFprh9pTvek6AwxR4k?=
 =?us-ascii?Q?IW31Qkuab95Okr8WeWy1tKNSy0NjznxA0Gd87GenG/54kINRiE5witZQkaPy?=
 =?us-ascii?Q?vAvt6frQzJcscpoaxg5KU8Qz3uSTOEFAvXWETulx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb5a2b70-2c91-4023-fa7a-08db1bad6769
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 06:06:18.3379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PLlrVuOzoEPlO0GCsUndLw4RkRoT1cOVJ1poBpNvBlSmsgq+6kmcMw7tDq2trrEZeBISHOf5qLeVTY/WnU2/bQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4527
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 04, 2023 at 09:34:54PM +0800, Guillaume Tucker wrote:
> Bring back the Python scripts that were initially added with
> TEST_GEN_FILES but now with TEST_FILES to avoid having them deleted
> when doing a clean.  Also fix the way the architecture is being
> determined as they should also be installed when ARCH=x86_64 is
> provided explicitly.  Then also append extra files to TEST_FILES and
> TEST_PROGS with += so they don't get discarded.
> 
> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> Fixes: ac527cee87c9 ("selftests: amd-pstate: Don't delete source files via Makefile")
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  tools/testing/selftests/amd-pstate/Makefile | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
> index 5fd1424db37d..c382f579fe94 100644
> --- a/tools/testing/selftests/amd-pstate/Makefile
> +++ b/tools/testing/selftests/amd-pstate/Makefile
> @@ -4,10 +4,15 @@
>  # No binaries, but make sure arg-less "make" doesn't trigger "run_tests"
>  all:
>  
> -uname_M := $(shell uname -m 2>/dev/null || echo not)
> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
> +ARCH ?= $(shell uname -m 2>/dev/null || echo not)
> +ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>  
> -TEST_PROGS := run.sh
> -TEST_FILES := basic.sh tbench.sh gitsource.sh
> +ifeq (x86,$(ARCH))
> +TEST_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
> +TEST_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> +endif
> +
> +TEST_PROGS += run.sh
> +TEST_FILES += basic.sh tbench.sh gitsource.sh
>  
>  include ../lib.mk
> -- 
> 2.30.2
>