Date:   Fri, 3 Mar 2023 14:13:38 +0800
From:   Yujie Liu <yujie.liu@intel.com>
To:     Dave Chinner <david@fromorbit.com>
CC:     Dave Chinner <dchinner@redhat.com>, <oe-lkp@lists.linux.dev>,
        <lkp@intel.com>, <linux-kernel@vger.kernel.org>,
        "Darrick J. Wong" <djwong@kernel.org>, <linux-xfs@vger.kernel.org>
Subject: Re: [linus:master] [xfs] 304a68b9c6:
 WARNING:at_fs/iomap/buffered-io.c:#iomap_write_delalloc_release
Message-ID: <ZAGQEtkTtJ3JeaPW@yujie-X299>
References: <202302281653.51938721-yujie.liu@intel.com>
 <20230228221107.GD360264@dread.disaster.area>
 <ZABgp1uBzcE49EG9@yujie-X299>
 <20230302222122.GJ360264@dread.disaster.area>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230302222122.GJ360264@dread.disaster.area>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SvIB8Sl8zFiVaQztCuZ5CzJaqC5jvG8bKKuadRc1MA7C/5LGw0DSsKoVvbTw?=
 =?us-ascii?Q?Nx+TQRSCdIYWF46hD0dFioM6JP5lo9WSC6sbQQGXSusYzyCumM7TUf/Z6CML?=
 =?us-ascii?Q?Gj4o091hDuKaZf8Vpc/YW16JjuGQZ+q93rfgMm4NoWt+TCvEWUb8Lj3wB8rH?=
 =?us-ascii?Q?javtY7Avrk/7tA92phSw9AX8bNDIacBSH3WT4NzW46Hw3ySvPBH0Fyf8EUNh?=
 =?us-ascii?Q?YqXzli8Jb8kJP5zUsbCtRWzoDQOntHlQ3ezZ9A7NHl9CSfjDFlAGSuIjFHyi?=
 =?us-ascii?Q?EhkSwEmlR+0AsoLXefCqR+ovH5FQA3lqkuTZOfkb8tYUIVNIsbyFmyCYPrHp?=
 =?us-ascii?Q?BUR/7KbeZrLwbDDOJVuHieSPVDwL+/vpH7bSRv/+OTFV++MqBNJ4DptyFged?=
 =?us-ascii?Q?5X+n41HW7TB8MkufUgEmlznLEBtrgT/Thon7ul4kvMeHg22CK2TwOBjx1tH7?=
 =?us-ascii?Q?usrO0LGqbZGRHic2GFdnqWKVbOTzdKN9rnqr6WEk+75RPjAkPoiN1DQWAgcO?=
 =?us-ascii?Q?ChCZuZvaIbhQIQMNT9cKFbotRDLw0N7a2XMWAkvby84Q+AIY8B3LIe6zzdFi?=
 =?us-ascii?Q?zVdRpn2NILUiWd68pV/p/kx2TzP/StsgMbjkLk6nIUVxwCxazcjiJ0tdEpkK?=
 =?us-ascii?Q?vH3EwY15npPjYpcZfXGkneuCAh0lKaFSkAIQLbGBLD+u9zgFIb5a0x55IAbj?=
 =?us-ascii?Q?lsJJjNFNxQ+a4zbw0TRYQ2GPkVg5H70pE3xl/ZuZB+rkRWNE5vJsJ5bGwj2W?=
 =?us-ascii?Q?t+QuVVBfH+FM7yTZgI7Id5Fw+gbKJvy1bNnmOltvJn0rk0cuJOg4ht268FPO?=
 =?us-ascii?Q?ctfQg/Z4GN5XJlGNA6ceg/VoTF1X2UyleqiK++A/wzVCRTyfdAfVsNmn8FXY?=
 =?us-ascii?Q?af8FMai9Bwvui5y3548eHlqmoJ+QnLNaO6aFmMltEmK4NjtRBC+7ngdIu8UQ?=
 =?us-ascii?Q?GcBFyUp+Y3Q9LsAd/MW37TiGzCXu/jpxVan/EAFebYtSDkArPIcBnWzm1CVB?=
 =?us-ascii?Q?6z+7T4Cmd/Ajuvi4T1ywAeoAWZAWO2iWBkF5gZMnDqJmie/l6Tb2jclSmfbQ?=
 =?us-ascii?Q?1+XvdU7AbbZrc8VVLm+xJs5h0Xqe86HFefaxYAWIbUbqu4haU9kF7PBu9wbA?=
 =?us-ascii?Q?sp9FZnT6I6XwcSGPBgMSrB9fpmaUwY+j3YcCwl5dOcUORPHU3U2+w1Hp2i/I?=
 =?us-ascii?Q?zzlHuBTahDT2UkOeYlX/UZ39l6qHcuLTuYii/6uEaFJDhSqhm9xgbgLqpxkY?=
 =?us-ascii?Q?3ebRlrFoCt+9jxz1b6QtuwshORFXRbUvKoa4zd3AQmFjNRlrOwZtjDF+Ybzn?=
 =?us-ascii?Q?p9Y8GdIg35EWuxGWQbIAdo9lqO03rPEmrPXV7PVf0O9G/zkXZIkKYEA3Mif1?=
 =?us-ascii?Q?FBTAxo0oyI4lBIjaReqVfKS1fliKUVVC6SWWHQ8dfi61F2iR+yrw8OD0fZGJ?=
 =?us-ascii?Q?uYnpuMMMAgScIaIKYocCH/dbdzOKoOBVgWWq0fd2UqL1xTa7N2KFQ+e35cKQ?=
 =?us-ascii?Q?hGObAL8Rcbu08P6wKZAxzjHPzYDGruvuUJYb0yu07PfxzgWFp7vg+jk8p6Hp?=
 =?us-ascii?Q?55kR/u93J8o7TLrnbhuNhjrhhR3tuyLU/bdRWkJy?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 71697421-fae2-4914-70da-08db1baece66
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 06:16:20.6478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FZGAEaB6JuvMX8KTcMPrhACfci9KbX7zOJEr1JSNC1Ov/aGeTw10fPsSF0UBOKGux8oprfsm8GtNCqzT3Cw/gQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7659
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 03, 2023 at 09:21:22AM +1100, Dave Chinner wrote:
> On Thu, Mar 02, 2023 at 04:39:03PM +0800, Yujie Liu wrote:
> > On Wed, Mar 01, 2023 at 09:11:07AM +1100, Dave Chinner wrote:
> > > On Tue, Feb 28, 2023 at 04:40:01PM +0800, kernel test robot wrote:
> > > > Greeting,
> > > > 
> > > > FYI, we noticed WARNING:at_fs/iomap/buffered-io.c:#iomap_write_delalloc_release due to commit (built with gcc-11):
> > > > 
> > > > commit: 304a68b9c63bbfc1f6e159d68e8892fc54a06067 ("xfs: use iomap_valid method to detect stale cached iomaps")
> > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > > > 
> > > > [test failed on linux-next/master 058f4df42121baadbb8a980c06011e912784dbd2]
> > > > in testcase: xfstests
> > > > version: xfstests-i386-5a5e419-1_20220926
> > > > with following parameters:
> > > > 
> > > > 	disk: 4HDD
> > > > 	fs: xfs
> > > > 	test: generic-group-32
> > > 
> > > Which fstest was running at the time this warning was thrown?
> > 
> > It is fstests generic/648 running at that time.
> 
> Ok.
> 
> Can you add this patch and see if it fixes the problem?
> 
> https://lore.kernel.org/linux-xfs/20230301221227.GH360264@dread.disaster.area/

We applied this patch on commit 304a68b9c63b and tested it, but cannot
fix the problem.

=========================================================================================
compiler/disk/fs/kconfig/rootfs/tbox_group/test/testcase:
  gcc-11/4HDD/xfs/i386-debian-10.3-func/debian-11.1-i386-20220923.cgz/lkp-skl-d01/generic-group-32/xfstests

commit:
  d7b64041164c ("iomap: write iomap validity checks")
  304a68b9c63b ("xfs: use iomap_valid method to detect stale cached iomaps")
  e5a7d5f824ad ("xfs: fix off-by-one-block in xfs_discard_folio()")

d7b64041164ca177 304a68b9c63bbfc1f6e159d68e8 e5a7d5f824ad7409f85e2665d11
---------------- --------------------------- ---------------------------
       fail:runs  %reproduction    fail:runs  %reproduction    fail:runs
           |             |             |             |             |
           :6           50%           3:3          100%           3:3     dmesg.EIP:iomap_write_delalloc_release
           :6           50%           3:3          100%           3:3     dmesg.WARNING:at_fs/iomap/buffered-io.c:#iomap_write_delalloc_release

> > [ 78.565703][ T59] ------------[ cut here ]------------
> > [ 78.570983][ T59] WARNING: CPU: 4 PID: 59 at fs/iomap/buffered-io.c:984 iomap_write_delalloc_release (fs/iomap/buffered-io.c:984 (discriminator 1))
> 
> Ok, that is:
> 
> 	WARN_ON_ONCE(start_byte < punch_start_byte);
> 
> Which I can't immediately see how that happens. This is a 32-bit
> i386 kernel which we largely don't test or support, so maybe there's
> 32/64 bit variable size change problem somewhere in the code path
> being executed.
> 
> > [ 78.671542][ T59] Hardware name: Dell Inc. OptiPlex 7040/0Y7WYT, BIOS 1.2.8 01/26/2016
> > [ 78.679578][ T59] Workqueue: loop0 loop_rootcg_workfn [ loop]
> 
> Ok, so this is happening while writing to the loopback image file
> which is racing with cloning and removing the clone of the image
> file.
> 
> Looking at the rest of the trace, IO to the entire loopback file
> hung, but this warning doesn't explain that happening either.
> 
> I'll try to reproduce it, but I don't actually have an i386 test
> environment here (I haven't tested i386 at all the last 5-6
> years!) so it might be a while before I can get to testing this
> specific environment.
> 
> Do you see it reproduce on any other architecture, of just this one?

It can be reproduced on i386, but not on x86_64. Sorry that we don't
have machines of other architectures in the robot infrastructure.

=========================================================================================
commit/compiler/disk/fs/kconfig/rootfs/tbox_group/test/testcase:
  304a68b9c63bbfc1f6e159d68e8892fc54a06067/gcc-11/4HDD/xfs/x86_64-rhel-8.3-func/debian-11.1-x86_64-20220510.cgz/lkp-skl-d01/generic-group-32/xfstests

commit/compiler/disk/fs/kconfig/rootfs/tbox_group/test/testcase:
  304a68b9c63bbfc1f6e159d68e8892fc54a06067/gcc-11/4HDD/xfs/i386-debian-10.3-func/debian-11.1-i386-20220923.cgz/lkp-skl-d01/generic-group-32/xfstests

kconfig:
  x86_64-rhel-8.3-func
  i386-debian-10.3-func

x86_64-rhel-8.3-func   i386-debian-10.3-func
---------------- ---------------------------
       fail:runs  %reproduction    fail:runs
           |             |             |
           :3          100%           3:3     dmesg.EIP:iomap_write_delalloc_release
           :3          100%           3:3     dmesg.WARNING:at_fs/iomap/buffered-io.c:#iomap_write_delalloc_release

--
Best Regards,
Yujie