From:   "Shradha Todi" <shradha.t@samsung.com>
To:     "'Rob Herring'" <robh@kernel.org>
Cc:     <alim.akhtar@samsung.com>, <Sergey.Semin@baikalelectronics.ru>,
        <pankaj.dubey@samsung.com>, <jh80.chung@samsung.co>,
        <krzysztof.kozlowski+dt@linaro.org>, <devicetree@vger.kernel.org>,
        <lukas.bulwahn@gmail.com>, <hongxing.zhu@nxp.com>,
        <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <m.szyprowski@samsung.com>,
        <linux-kernel@vger.kernel.org>, <lpieralisi@kernel.org>,
        <tglx@linutronix.de>, <linux-samsung-soc@vger.kernel.org>,
        <kw@linux.com>, <jingoohan1@gmail.com>
In-Reply-To: <167638944926.3699.15638999253407034271.robh@kernel.org>
Subject: RE: [PATCH 05/16] dt-bindings: PCI: Rename the term elbi to appl
Date:   Thu, 2 Mar 2023 18:17:14 +0530
Message-ID: <139201d94d05$26da8290$748f87b0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHB3D0FgV9/Br8Y35oSVRdB1anKHwG8wiHRAhWtsysBm4ANqa7q4hdA
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20230214121333.1837-1-shradha.t@samsung.com>
        <CGME20230214121424epcas5p38e74b52a2d94a32b82a093c7e0a12499@epcas5p3.samsung.com>
        <20230214121333.1837-6-shradha.t@samsung.com>
        <167638944926.3699.15638999253407034271.robh@kernel.org>
Precedence: bulk


> -----Original Message-----
> From: Rob Herring =5Bmailto:robh=40kernel.org=5D
> Sent: 14 February 2023 21:43
> To: Shradha Todi <shradha.t=40samsung.com>
> Cc: alim.akhtar=40samsung.com; Sergey.Semin=40baikalelectronics.ru;
> pankaj.dubey=40samsung.com; jh80.chung=40samsung.co;
> krzysztof.kozlowski+dt=40linaro.org; devicetree=40vger.kernel.org;
> lukas.bulwahn=40gmail.com; hongxing.zhu=40nxp.com; bhelgaas=40google.com;
> linux-pci=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org;
> m.szyprowski=40samsung.com; linux-kernel=40vger.kernel.org;
> lpieralisi=40kernel.org; tglx=40linutronix.de; linux-samsung-
> soc=40vger.kernel.org; kw=40linux.com; jingoohan1=40gmail.com
> Subject: Re: =5BPATCH 05/16=5D dt-bindings: PCI: Rename the term elbi to =
appl
>=20
>=20
> On Tue, 14 Feb 2023 17:43:22 +0530, Shradha Todi wrote:
> > DT uses the name elbi in reg-names for application logic registers
> > which is a wrong nomenclature. This patch fixes the same.
> >
> > This commit shouldn't be applied without changes
> > =22arm64: dts: Rename the term elbi to appl=22 and
> > =22PCI: samsung: Rename the term elbi to appl=22
> >
> > Signed-off-by: Shradha Todi <shradha.t=40samsung.com>
> > ---
> >  Documentation/devicetree/bindings/pci/samsung,pcie.yaml =7C 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
>=20
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>=20
> yamllint warnings/errors:
>=20
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/pci/samsung,pcie.example.dtb
> : pcie=4015700000: reg-names:1: 'appl' was expected
> 	From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/pci/samsung,pcie.yaml
>=20
> doc reference errors (make refcheckdocs):
>=20
> See https://protect2.fireeye.com/v1/url?k=3Db0812da3-d10a3895-b080a6ec-
> 74fe485fffe0-cf137b875436d997&q=3D1&e=3D09e1c000-01c6-48c4-8fff-
> 94e474b2862c&u=3Dhttps%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fdev
> icetree-bindings%2Fpatch%2F20230214121333.1837-6-
> shradha.t%40samsung.com
>=20
> The base for the series is generally the latest rc1. A different dependen=
cy
> should be noted in *this* patch.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above error=
(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>=20
> pip3 install dtschema --upgrade
>=20
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.

Thanks for review. Sorry, I missed to update the example. Will take care in=
 next patch set.