From:   "Shradha Todi" <shradha.t@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <lpieralisi@kernel.org>, <kw@linux.com>, <robh@kernel.org>,
        <bhelgaas@google.com>, <krzysztof.kozlowski+dt@linaro.org>,
        <alim.akhtar@samsung.com>, <jingoohan1@gmail.com>,
        <Sergey.Semin@baikalelectronics.ru>, <lukas.bulwahn@gmail.com>,
        <hongxing.zhu@nxp.com>, <tglx@linutronix.de>,
        <m.szyprowski@samsung.com>, <jh80.chung@samsung.co>,
        <pankaj.dubey@samsung.com>
Cc:     <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <4e7f3fe5-3a5e-d4c3-d513-642184bbdb23@linaro.org>
Subject: RE: [PATCH 02/16] PCI: exynos: Rename Exynos PCIe driver to Samsung
 PCIe
Date:   Thu, 2 Mar 2023 18:27:52 +0530
Message-ID: <139601d94d06$9bd85990$d3890cb0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHB3D0FgV9/Br8Y35oSVRdB1anKHwIi2RiTAnipn4AB4ctyRQE87kyXrtiCLVA=
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20230214121333.1837-1-shradha.t@samsung.com>
        <CGME20230214121411epcas5p25efd5d4242c512f21165df0c2e81b8bc@epcas5p2.samsung.com>
        <20230214121333.1837-3-shradha.t@samsung.com>
        <d0d1db7e-e2a7-dddf-5c28-fed330b44cdb@linaro.org>
        <4e7f3fe5-3a5e-d4c3-d513-642184bbdb23@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
> Sent: 16 February 2023 16:29
> To: Shradha Todi <shradha.t=40samsung.com>; lpieralisi=40kernel.org;
> kw=40linux.com; robh=40kernel.org; bhelgaas=40google.com;
> krzysztof.kozlowski+dt=40linaro.org; alim.akhtar=40samsung.com;
> jingoohan1=40gmail.com; Sergey.Semin=40baikalelectronics.ru;
> lukas.bulwahn=40gmail.com; hongxing.zhu=40nxp.com; tglx=40linutronix.de;
> m.szyprowski=40samsung.com; jh80.chung=40samsung.co;
> pankaj.dubey=40samsung.com
> Cc: linux-pci=40vger.kernel.org; devicetree=40vger.kernel.org; linux-arm-
> kernel=40lists.infradead.org; linux-samsung-soc=40vger.kernel.org; linux-
> kernel=40vger.kernel.org
> Subject: Re: =5BPATCH 02/16=5D PCI: exynos: Rename Exynos PCIe driver to
> Samsung PCIe
>=20
> On 16/02/2023 11:55, Krzysztof Kozlowski wrote:
> > On 14/02/2023 13:13, Shradha Todi wrote:
> >> The current PCIe controller driver is being used for Exynos5433 SoC
> >> only. In order to extend this driver for all SoCs manufactured by
> >> Samsung using DWC PCIe controller, rename this driver and make it
> >> Samsung specific instead of any Samsung SoC name.
> >>
> >> Signed-off-by: Shradha Todi <shradha.t=40samsung.com>
> >> ---
> >>  MAINTAINERS                              =7C   4 +-
> >>  drivers/pci/controller/dwc/Kconfig       =7C   6 +-
> >>  drivers/pci/controller/dwc/Makefile      =7C   2 +-
> >>  drivers/pci/controller/dwc/pci-samsung.c =7C 443
> >> +++++++++++++++++++++++
> >
> > Rename missing. I am anyway not sure if this is good. What's wrong
> > with old name?
>=20
> OK, looking a bit at your further patches - doesn't it make sense to spli=
t a bit
> the driver? Maybe keep the core as pci-samsung, but some other parts in
> pci-exynso5433?
>=20

Ok agreed. So here is what I am planning, keeping in mind the next set of p=
latform support which I am planning to send out (say FSD, ARTPEC-v8):
1: We will move samsung pci driver inside dwc/samsung/
2: pci-samsung.c shall contain common APIs, helper functions, etc
3: Platform specific driver will have their own files such as pcie-exynos.c=
, pcie-fsd.c, pcie-artpec-v8.c=20
Let me know what you think of this.
I am not very keen on renaming Exynos SoC file as pcie-exyons5433.c as in f=
uture we may end up adding PCIe support for other Exynos which being
in same family (Exynos Series) will be very similar in design. Custom ASIC =
(manufactured by Samsung Foundry) is primarily driven by various
vendors and will have separate design in terms of integration of IPs in SoC=
 and we need to have support for all such SoCs manufactured under Samsung u=
mbrella.

Shradha

> Best regards,
> Krzysztof