Date:   Fri, 3 Mar 2023 10:53:41 +0000
From:   Lee Jones <lee@kernel.org>
To:     Nick Alcock <nick.alcock@oracle.com>
Cc:     mcgrof@kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org
Subject: Re: [PATCH 10/27] leds: remove MODULE_LICENSE in non-modules
Message-ID: <20230303105341.GC2420672@google.com>
References: <20230224150811.80316-1-nick.alcock@oracle.com>
 <20230224150811.80316-11-nick.alcock@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230224150811.80316-11-nick.alcock@oracle.com>
Precedence: bulk

On Fri, 24 Feb 2023, Nick Alcock wrote:

> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Lee Jones <lee@kernel.org>
> Cc: linux-leds@vger.kernel.org
> ---
>  drivers/leds/leds-asic3.c | 1 -
>  1 file changed, 1 deletion(-)

Mention the driver in the subject line please.

> diff --git a/drivers/leds/leds-asic3.c b/drivers/leds/leds-asic3.c
> index 8cbc1b8bafa5..bc7e96c3732a 100644
> --- a/drivers/leds/leds-asic3.c
> +++ b/drivers/leds/leds-asic3.c
> @@ -173,5 +173,4 @@ module_platform_driver(asic3_led_driver);
>  
>  MODULE_AUTHOR("Paul Parsons <lost.distance@yahoo.com>");
>  MODULE_DESCRIPTION("HTC ASIC3 LED driver");
> -MODULE_LICENSE("GPL");
>  MODULE_ALIAS("platform:leds-asic3");
> -- 
> 2.39.1.268.g9de2f9a303
> 

-- 
Lee Jones [李琼斯]