Message-ID: <2d221713-cafa-8460-df6b-ccd11f42e4cb@intel.com>
Date:   Fri, 3 Mar 2023 12:12:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH net v3] ice: copy last block omitted in
 ice_get_module_eeprom()
Content-Language: en-US
To:     Petr Oros <poros@redhat.com>
CC:     <netdev@vger.kernel.org>, <jesse.brandeburg@intel.com>,
        <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <scott.w.taylor@intel.com>, <intel-wired-lan@lists.osuosl.org>,
        <linux-kernel@vger.kernel.org>
References: <20230301204707.2592337-1-poros@redhat.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230301204707.2592337-1-poros@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzBlTUQ2Y056R2tqOTBObVU0VTVkQUFGbzRoSmRNNWlZZHBHR21aNmxnOSti?=
 =?utf-8?B?V3BnTjVGQzNVVVFuYkc1SEk1RVh3TWhGaFcwaG9GMVp0Y3p5L2VwVW4zWUF0?=
 =?utf-8?B?U0V3b3Y0Qjc5VEhYbFJIT0VMRExqVkFJTVh1VGgzcWVEYnpxWTNuU0VjL2Zu?=
 =?utf-8?B?bWFyYXlFbFA4d2F0UkpzanoxdU5JZ0ZZV1djemZKWklZY211SWdzYnl3RHlm?=
 =?utf-8?B?eG1jVFlHblRxOUdDa1FXeTlrNSszZ2xmcjlUaDZFMlJpSWZRNUtjT1ZFUm1z?=
 =?utf-8?B?WmhlOU5HT0JNaTRkcHZwRHFlMWVISUpqOVZQVFNZYzFBU3VwVVQ2RmJNdmlC?=
 =?utf-8?B?NlVReEh4NnR3OUFWRVhoUDFyc21ld3Q2ODBqaUFRV2FROXVjQ2lWcldjKzFG?=
 =?utf-8?B?dHRYNW9NNmJiNGNHMi9hMzVOcjlkd0pRdk9Dand4ZkpKZ0UrK2F4RTBrdkJ1?=
 =?utf-8?B?NGl5UG1vZnIyclZBamFHTWNlMHhCYnRZSVQxcEZMVm9jRGZIMFhUMTZKMVdC?=
 =?utf-8?B?L2hlNGRjdUJBNHF5aktXWmpKMUV6UG81VTZYME0rR2NGeDltVDU1bWZDbU5j?=
 =?utf-8?B?d09tYW1EK1ZiZ3NOT3hyNU9HOGN3SkN0UitKVFhHcDJnZ0djZmpOSUtjWVA0?=
 =?utf-8?B?OHNlYnRwQTAwbm04OTFCS1djT2JOeThOTjhhcFh6SEIrcUh3TlRwRHd1L0pv?=
 =?utf-8?B?MllUcUpnblViNHV3V0RKdUtYcEdNN09iZUZaRU0xcnNXK0NyTE9tdnBLVEZs?=
 =?utf-8?B?VHB5L0huS29VUFAxRitxVFN1eDd0Tk9MZEdYcjA5dThyKzJrZDU3Rm1QNFAz?=
 =?utf-8?B?NVFvdjRHSmJhbTZPV25uKysyRzZEOFQzWllLcWZ1dGJVc05RSVNzNFV5djlK?=
 =?utf-8?B?STJNMjQ5SGw5UCtpeFF5dUpCMTl2WHY2SVlYMURSWXdHMnhXR3F3TnIxdUZ2?=
 =?utf-8?B?bGtJdkZGZ29xQnpJZWIzTmFEb3BkYVg2bTgxRUNFVUlzTHFEN3R5NzBLTUJY?=
 =?utf-8?B?YVl0cndWWmNKNmpaaW1FL0o2eUVNOVAwNHBiRmk2OWk2bGRlRTNKSDNLdy9y?=
 =?utf-8?B?OHRQVU4xZlJoVnllOHZ1TTZCKzNCVkkrcEZuOHZRMnV5UGQvZERCRVJ4NlE1?=
 =?utf-8?B?UWw1UUtURUdxN3Z4UUZLb29mb29hMTRlckIrL3YrR1Uyb0J6UFFwM04wdHhz?=
 =?utf-8?B?eVVJN20wYnpSVGwrRUxHTzVDZnUvbUdXbUhXKzBOSDZEeFQyTG1qT0Y3a3I4?=
 =?utf-8?B?WUthMi9FZHhxSk4rUWpFTFRYKy9zK2d6eDdUSmt0T1M2bDFPS01nNWZhRGgy?=
 =?utf-8?B?bXR1Q3lQRTYydjRER1RWOTl1cjZCWFQwMWNVV3BKNUFoakQ1U2luVm5Bd2Jz?=
 =?utf-8?B?QVFTRmZseGswVktyVUhOZGh0Z1RkZ1Jkak14VVprUGdZajd5dHNKc1AwUUZj?=
 =?utf-8?B?Vk9DYXQvTWh4L2liVllpdEN5MDB2ZzdSaGpKM1pmaDgyYlk1cHdmMmhDbFNh?=
 =?utf-8?B?SFNFYmZuZ0psYW9QT1pZYjhVcTRJWEJDZnBqOU55dGIwSFIxSGJHL2ZuQ3o2?=
 =?utf-8?B?cnhXMXdocmowMUdBdnp1Z1d0STQxbGhybE5PdmVHZVNBYTJVNzVhakdKTk5a?=
 =?utf-8?B?NzJGc2JmYldRSlRNMEhOUU80ckxJMDRsNmZEakFBU0w5cHVCZFBWNGdHUE52?=
 =?utf-8?B?NytVSThPazRhaG9kNHVQRE9sN1pUbnlxbER3ZHJrc1laczVJS1phOVlJb1hi?=
 =?utf-8?B?MkltSG80UjV4UzVpd05lRXB4cjh1RldBSzNsQUpyaXdualUvMFZGVDMyWlJ3?=
 =?utf-8?B?ZittKzlaakJ4TlBXVTdSenpBR1AvMU5kNU03T0lXM1BDQ3J4dURtc1dITmxX?=
 =?utf-8?B?M0x0Q3p3aVRITHp1WlZ6dGtWc3dWUjhvVzUrZUlwamtCQmdCeW5aRDZNSmdZ?=
 =?utf-8?B?QVRaREZrU3lML2F5QTl1LzJyZmVuU3lyNzhCU2hmQU1FdkFzQ1Z1bHFKeExk?=
 =?utf-8?B?b2xwL1FqZURWYmF5cUJrWUNwZXkwYmo0L3NxQVF6aVViaWZVcjBTMHErdUdF?=
 =?utf-8?B?UXN4c2t5Q0FleVFsUjJ0MnRlcnc5bXdXZ2MzZGNxTHVsb2JzS0c5UDcrODVo?=
 =?utf-8?B?RUlOOWVMMzBSSzVnQWJyUFltVld5eXFDdDJqekMzbnJsWjQwQkowT2lNRVZK?=
 =?utf-8?Q?Gg/JxfDT2YkNn6PFZmZdrs4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e93a015-02ea-4b50-97a5-08db1bd8553d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 11:13:36.5042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O+vH+Nx5R7jT97RF6MsbVOzeEE2DryHaicMuEfOodhoSmzdtX387Kl6w+fjkMYSPRGtkg4CrQKPz/SNmGfjKTCpI8jaFu0MFi9MXH2JXJus=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6057
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Petr Oros <poros@redhat.com>
Date: Wed,  1 Mar 2023 21:47:07 +0100

> ice_get_module_eeprom() is broken since commit e9c9692c8a81 ("ice:
> Reimplement module reads used by ethtool") In this refactor,
> ice_get_module_eeprom() reads the eeprom in blocks of size 8.
> But the condition that should protect the buffer overflow
> ignores the last block. The last block always contains zeros.

[...]

> Fixes: e9c9692c8a81 ("ice: Reimplement module reads used by ethtool")
> Signed-off-by: Petr Oros <poros@redhat.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
> v2: memcpy unified calls
> v3: copy_len is now declared in if scope
>     unwrapped line before memcpy
[...]

Thanks,
Olek