Message-ID: <2995ad71-5058-2cf9-78ff-0d32ea620514@intel.com>
Date:   Fri, 3 Mar 2023 12:31:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH bpf-next v1 0/2] xdp: recycle Page Pool backed skbs built
 from XDP frames
Content-Language: en-US
To:     Jesper Dangaard Brouer <jbrouer@redhat.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>, <brouer@redhat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>,
        Song Liu <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>, <bpf@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230301160315.1022488-1-aleksander.lobakin@intel.com>
 <22ca47ca-325f-f4df-af5d-344be6b372d8@redhat.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <22ca47ca-325f-f4df-af5d-344be6b372d8@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlpDemdmKzMwU2ZqaUFVOTRnakE0STArY1dhWXJyelVUUFRqcXF6RTJmTWFI?=
 =?utf-8?B?RURSSy9TNmxuTTU4d3BRUVRTSHI2Wlh2ZnNSb04rOHBQZi9MOEIxZU4vOTNN?=
 =?utf-8?B?czVyUmJwZGN0aUErcEdXaEFham1wdStISTRKd2hEaHBQUi9PMGtSVG9HZXEx?=
 =?utf-8?B?SnlIUjVzTnMyVmdaSWJIVFN0blNPYkt2eGtjMU5Zdks0YjdCTDI0SWZyVW5X?=
 =?utf-8?B?OGxJMUN0NDhNTFppTWVYMGszaHdYOVBsS0FsSlRldXBtTkpBS1l6OTV4SitR?=
 =?utf-8?B?ZEt1QUFkbm44eTluMC92bFhoOU9uNkp6RDVtMzdWTFJ2Q0s2ZnNzTjBUbng5?=
 =?utf-8?B?cGRSMktkSXY3VUtqcytLTktnVVZDcWdDTllhR0UwV0ErU1NyVEFHa2VDMWJk?=
 =?utf-8?B?eWdpVHJjT1h5a1V6SXltdTJRMk9WbVhMWFdWY1NtQ2U2a3BKMGJiOWFYcWhP?=
 =?utf-8?B?UDdTUEJTeEpVTWlYUkZzUmRZdWpOSGZHTW5YNmxYVkt2NkhZelZtcU1TRElW?=
 =?utf-8?B?VHhtTTVSNzBYMGVtT2NucjhweUc1bHZyNG1rRlZjdmh0emZOWVVHd1RTNU1J?=
 =?utf-8?B?b0IvSzg0VXBwUnJoUnBCdmYvSDlEcTlzTEpwSjYwNHJwSFgyY0ZKMDdYZzVY?=
 =?utf-8?B?ZEpVZWxsaUxzWVpvQVQ0NElUVXhEbzRmQUREY01ySTlXbXBPQTZPR05VK0Ew?=
 =?utf-8?B?bzNaUzRLWTAvMnArNU9ONHBEdUNSbmlnM3FoY014dEU0dGhpZE1CRjZsRUFk?=
 =?utf-8?B?RmRzTENHQmF1WmdhczRwVUl3TG9aNUpnajdldFhUZHhvZlhKdDFseFZHVndr?=
 =?utf-8?B?OEV4VzB3ZDcwY2ltZm9PWG4rWjhlQ0pHN3RCTnN6MUtkQVZtZVZ3YWlkVm1U?=
 =?utf-8?B?RUIxUHVQb3JsQVVIM0d4bmRHdGF5aUlucUVEUmIveHhZNEkvTmJVZ3BySy9n?=
 =?utf-8?B?Q1lhT3AzWWthTU9QM2RNUXM4azV5K21sZ0ZMZks5cnVBNEsyUFlReFZVQzJn?=
 =?utf-8?B?UjYvek9LS3BpN2x1MXQrN1FDMFExMnpZUTJpVEpWZFkzVFZIek1xK3NxRkZz?=
 =?utf-8?B?dW5QdmNOU0doTVBBVVlIODRqR3Y4aE5aMjc0Z0M3U21Kd0ZzYVlCc2xvckp0?=
 =?utf-8?B?SmU2T1RFdThieDYzSFJVRWV3NUtIMzVZQ0RWZWZYMGlPUmZoZ0I0a1Q1SFhZ?=
 =?utf-8?B?RnhhTFFoY1lOdkVXWEFYMFdVUnpBV3dXYVhKdE84M3ZTZDVmYWNZOTZmZ2ZY?=
 =?utf-8?B?Mk9QY0lROXowWGJzdW5vanUvRjhEdUMvWVlWZnk5SjN1TVp0cUMrNmZ4UWdp?=
 =?utf-8?B?SUNCVnVTMzE0MjBoOENvMVJod0hIcXZVVFNCMzM5b0FQNkM3S1BmeDY0N050?=
 =?utf-8?B?enJnaVBJVUx0akdvQUk1KzZaajhIVm55NGsvOFZSd3JNRFB1RThza1paSUJK?=
 =?utf-8?B?T3gxRTEwNnpVUmtEeUZ3SmozVkg2bGIxVGtnaVB6OW1yb0o2bjFaa2tVaFBh?=
 =?utf-8?B?TWJuSzZ2Z0ZNei9yUlUzcWdPbFlKZldEMWhabUZnbTBpbUxuend2ZnFGcEMr?=
 =?utf-8?B?NE1yaHZ6UHMwOHJwM1g4WEMySllBRFVTQy9reUtmNjFUMHVsZlh4KzV3Qnd6?=
 =?utf-8?B?dmV0ZEJDVytyVlVWaUFTWnRuNW9EVlZnNk4rblVYejJxYmtuaW9jVkk4bTZ5?=
 =?utf-8?B?c2NZaEUzTERIcGhjcGkvUnEvckltRzFyWTh5OWJ6L1hFZzc1dzZBR2xTYkl2?=
 =?utf-8?B?T1Z6dktqT0oyYVRqWFRQRU44RGlDYWVGVFVkZGk0aCs1S0p0U21hUitwazk4?=
 =?utf-8?B?bld4aFVtRFUwa0ltbEVUTHViZzVxdEprWm9EQTZxVEg2bXNzQ05xUVNNemNl?=
 =?utf-8?B?S1F6SDdya1ZJTVdjZk5WTTBUaXV5Y1RYdnR3R1RIaURTNlN1WEgyYUdEbEpw?=
 =?utf-8?B?WGVJZVh4enNRaDhYVFc5N3hBSVJUS25WRzRGV3JKcGZBbExpYWp5SnRuWGJQ?=
 =?utf-8?B?NmNHY3h3ckIvUVpscEJmWm01QWE0cTV0UkRaOEJXRitOTlBCVFc5ZjVuSVRU?=
 =?utf-8?B?WUtFOGF6ZDRzdlJOUGhWRzM1SFZwZHhnSWFUV29McVpydUhkY3BKY05nQjZD?=
 =?utf-8?B?aWlZbVhreUFNT0FGdFBoZis5Tis0Z2pHQjY3YmZqbUFHTHVOZ2FFUThLZW9C?=
 =?utf-8?Q?UPkHKEY/0X5Gh7bYCQ4uycM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 13d29da4-a56e-4db5-a91e-08db1bdb0261
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 11:32:45.7611
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KQlbbiJOYUd2qiTqkdhuUsODJkwT+qb2hArwOQTZ3loBvAF9K69GX+eubjMmMcFZNamMQCRRMAGyvi5E1IVH3Sf+1J2yrcvC/dk9qvX/z3g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6431
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jesper Dangaard Brouer <jbrouer@redhat.com>
Date: Fri, 3 Mar 2023 11:39:06 +0100

> 
> On 01/03/2023 17.03, Alexander Lobakin wrote:
>> Yeah, I still remember that "Who needs cpumap nowadays" (c), but anyway.
>>
>> __xdp_build_skb_from_frame() missed the moment when the networking stack
>> became able to recycle skb pages backed by a Page Pool. This was making
>                                                ^^^^^^^^^
> When talking about page_pool, can we write "page_pool" instead of
> capitalized "Page Pool", please. I looked through the git log, and here
> we all used "page_pool".

Ah okay, no prob :D Yeah, that's probably more correct. "Page Pool" is
the name of the API, while page_pool is an entity we create via
page_pool_create().

> 
>> e.g. cpumap redirect even less effective than simple %XDP_PASS. veth was
>> also affected in some scenarios.
> 
> Thanks for working on closing this gap :-)
> 
>> A lot of drivers use skb_mark_for_recycle() already, it's been almost
>> two years and seems like there are no issues in using it in the generic
>> code too. {__,}xdp_release_frame() can be then removed as it losts its
>> last user.
>> Page Pool becomes then zero-alloc (or almost) in the abovementioned
>> cases, too. Other memory type models (who needs them at this point)
>> have no changes.
>>
>> Some numbers on 1 Xeon Platinum core bombed with 27 Mpps of 64-byte
>> IPv6 UDP:
> 
> What NIC driver?

IAVF with XDP, the series adding XDP support will be sent in a couple
weeks, WIP can be found on my open GH[0].

> 
>>
>> Plain %XDP_PASS on baseline, Page Pool driver:
>>
>> src cpu Rx     drops  dst cpu Rx
>>    2.1 Mpps       N/A    2.1 Mpps
>>
>> cpumap redirect (w/o leaving its node) on baseline:
>>
>>    6.8 Mpps  5.0 Mpps    1.8 Mpps
>>
>> cpumap redirect with skb PP recycling:
>>
>>    7.9 Mpps  5.7 Mpps    2.2 Mpps   +22%
>>
> 
> It is of cause awesome, that cpumap SKBs are faster than normal SKB path.

That's the point of cpumap redirect, right? You separate NAPI poll / IRQ
handling from the skb networking stack traveling to a different CPU,
including page freeing (or recycling). That takes a lot of load from the
source CPU. 0.1 Mpps is not the highest difference I got, cpumap
redirect can boost up to 0.5 Mpps IIRC.

> I do wonder where the +22% number comes from?

(2.2 - 1.8) / 1.8 * 100%. I compare baseline cpumap redirect
before/after here :)

> 
>> Alexander Lobakin (2):
>>    xdp: recycle Page Pool backed skbs built from XDP frames
>>    xdp: remove unused {__,}xdp_release_frame()
>>
>>   include/net/xdp.h | 29 -----------------------------
>>   net/core/xdp.c    | 19 ++-----------------
>>   2 files changed, 2 insertions(+), 46 deletions(-)
>>
> 

There's a build failure on non-PP systems due to skb_mark_for_recycle()
being declared only when CONFIG_PAGE_POOL is set. I'll spin v2 in a bit.

[0] https://github.com/alobakin/linux/commits/iavf-xdp

Thanks,
Olek