MIME-Version: 1.0
References: <20230302194235.1724-1-mario.limonciello@amd.com> <20230302194235.1724-10-mario.limonciello@amd.com>
In-Reply-To: <20230302194235.1724-10-mario.limonciello@amd.com>
From:   Grzegorz Bernacki <gjb@semihalf.com>
Date:   Fri, 3 Mar 2023 12:57:07 +0100
Message-ID: <CAA2Cew7emsVMmKk1jz+XYnYKJasZ3w35jh-+8TFTG5UCD88eHA@mail.gmail.com>
Subject: Re: [PATCH v2 9/9] crypto: ccp: Add doorbell register offset
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>,
        Rijo-john.Thomas@amd.com, Thomas.Lendacky@amd.com,
        herbert@gondor.apana.org.au, John Allen <john.allen@amd.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Mario,

It won't work as expected since the Skyrim device has a different
offset of cmdresp_reg, which is 0x10a40 and doorbell is actually
0x10a24. I apologize for giving you the wrong values.
thanks,
greg

czw., 2 mar 2023 o 20:43 Mario Limonciello <mario.limonciello@amd.com>
napisa=C5=82(a):
>
> The PSP in Skyrim uses i2c arbitration with a doorbell.
> Add this offset so that the communication can work.
>
> Link: Link: https://lore.kernel.org/linux-i2c/20220916131854.687371-3-jsd=
@semihalf.com/
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v1->v2:
>  * New patch
> ---
>  drivers/crypto/ccp/sp-pci.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index 18aa902eb5ce..a4efcaee43d8 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -365,6 +365,7 @@ static const struct platform_access_vdata pa_v1 =3D {
>         .cmdresp_reg            =3D 0x10570,      /* C2PMSG_28 */
>         .cmdbuff_addr_lo_reg    =3D 0x10574,      /* C2PMSG_29 */
>         .cmdbuff_addr_hi_reg    =3D 0x10578,      /* C2PMSG_30 */
> +       .doorbell_reg           =3D 0x10a40,      /* C2PMSG_80 */
>  };
>
>  static const struct psp_vdata pspv1 =3D {
> --
> 2.34.1
>