MIME-Version: 1.0
References: <20230302194235.1724-1-mario.limonciello@amd.com> <20230302194235.1724-9-mario.limonciello@amd.com>
In-Reply-To: <20230302194235.1724-9-mario.limonciello@amd.com>
From:   Grzegorz Bernacki <gjb@semihalf.com>
Date:   Fri, 3 Mar 2023 13:00:02 +0100
Message-ID: <CAA2Cew5YyufrBZqAA4A5R=1vf_dn=c3ftwziTjzFSm8S5LJZGg@mail.gmail.com>
Subject: Re: [PATCH v2 8/9] i2c: designware: Add doorbell support for Skyrim
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>,
        Rijo-john.Thomas@amd.com, Thomas.Lendacky@amd.com,
        herbert@gondor.apana.org.au,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Mario,

I am not sure if adding a new ACPI ID is a good idea. Actually we are
talking about the same devices. The only difference is in the
communication protocol between PSP and CPU. This could be easily
detected at runtime by checking cpu id. There is no need to introduce
a new id and create dependency on the FW version.

thanks,
greg

czw., 2 mar 2023 o 20:43 Mario Limonciello <mario.limonciello@amd.com>
napisa=C5=82(a):
>
> Skyrim doesn't use the platform feature mailbox for communication
> for I2C arbitration, it relies upon ringing a doorbell.
>
> Add a new ACPI ID to use for Skyrim and when that ID is detected
> use the doorbell instead.
>
> Link: https://lore.kernel.org/linux-i2c/20220916131854.687371-3-jsd@semih=
alf.com/
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v1->v2:
>  * New patch
> Note: This ACPI ID hasn't currently been reserved, but as Skyrim runs cor=
eboot
> it should be easy enough to modify the BIOS and test it out.
> If this approach works and has general agreement it can be reserved.
> ---
>  drivers/i2c/busses/i2c-designware-amdpsp.c  | 29 ++++++++++++++-------
>  drivers/i2c/busses/i2c-designware-platdrv.c |  1 +
>  2 files changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/bus=
ses/i2c-designware-amdpsp.c
> index 105584abcf8f..e1a4d3002c80 100644
> --- a/drivers/i2c/busses/i2c-designware-amdpsp.c
> +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
> @@ -73,34 +73,44 @@ static int psp_send_check_i2c_req(struct psp_i2c_req =
*req)
>         return check_i2c_req_sts(req);
>  }
>
> -static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
> +static int psp_send_i2c_req_amdi0019(enum psp_i2c_req_type i2c_req_type)
>  {
>         struct psp_i2c_req *req;
> -       unsigned long start;
>         int status, ret;
>
>         /* Allocate command-response buffer */
>         req =3D kzalloc(sizeof(*req), GFP_KERNEL);
>         if (!req)
>                 return -ENOMEM;
> -
>         req->hdr.payload_size =3D sizeof(*req);
>         req->type =3D i2c_req_type;
> -
> -       start =3D jiffies;
>         ret =3D read_poll_timeout(psp_send_check_i2c_req, status,
>                                 (status !=3D -EBUSY),
>                                 PSP_I2C_REQ_RETRY_DELAY_US,
>                                 PSP_I2C_REQ_RETRY_CNT * PSP_I2C_REQ_RETRY=
_DELAY_US,
>                                 0, req);
> -       if (ret) {
> +       kfree(req);
> +
> +       if (ret)
>                 dev_err(psp_i2c_dev, "Timed out waiting for PSP to %s I2C=
 bus\n",
>                         (i2c_req_type =3D=3D PSP_I2C_REQ_ACQUIRE) ?
>                         "release" : "acquire");
> -               goto cleanup;
> -       }
>
> -       ret =3D status;
> +       return ret ? ret : status;
> +}
> +
> +static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
> +{
> +       const char *hid =3D acpi_device_hid(ACPI_COMPANION(psp_i2c_dev));
> +       unsigned long start =3D jiffies;
> +       int ret;
> +
> +       /* Use doorbell for Skyrim and mailbox for Cezanne */
> +       if (!strcmp(hid, "AMDI0020"))
> +               ret =3D psp_ring_platform_doorbell(i2c_req_type);
> +       else
> +               ret =3D psp_send_i2c_req_amdi0019(i2c_req_type);
> +
>         if (ret) {
>                 dev_err(psp_i2c_dev, "PSP communication error\n");
>                 goto cleanup;
> @@ -115,7 +125,6 @@ static int psp_send_i2c_req(enum psp_i2c_req_type i2c=
_req_type)
>                 psp_i2c_mbox_fail =3D true;
>         }
>
> -       kfree(req);
>         return ret;
>  }
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/bu=
sses/i2c-designware-platdrv.c
> index 89ad88c54754..5ca71bda9ac2 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -51,6 +51,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] =
=3D {
>         { "AMD0010", ACCESS_INTR_MASK },
>         { "AMDI0010", ACCESS_INTR_MASK },
>         { "AMDI0019", ACCESS_INTR_MASK | ARBITRATION_SEMAPHORE },
> +       { "AMDI0020", ACCESS_INTR_MASK | ARBITRATION_SEMAPHORE },
>         { "AMDI0510", 0 },
>         { "APMC0D0F", 0 },
>         { "HISI02A1", 0 },
> --
> 2.34.1
>