Date:   Fri, 3 Mar 2023 15:27:15 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Nick Terrell <terrelln@meta.com>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] zstd: Fix definition of assert()
Message-ID: <ZAIDw1Qq0W77XQ94@probook>
References: <20230129131436.1343228-1-j.neuschaefer@gmx.net>
 <C1912105-5951-4627-83B6-BA84420FED0D@meta.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kPTYGsB/x7M2pU5I"
Content-Disposition: inline
In-Reply-To: <C1912105-5951-4627-83B6-BA84420FED0D@meta.com>
UI-OutboundReport: notjunk:1;M01:P0:rIXYa91AtWc=;tw3ekBJrHaXmWZix1vn+YwuIhiF
 RnyYibSvPC9NEtgDcC1OclLWAshSanZe88viBIHdG6N1qJU9+oVHrSp2ZHCRVqbEKDThb0XKr
 +waGrePwhDZcXy9A5cN+hsWzAeu6i82zxBcOYr1ZeXKCT+4Q3Blex2rrLCCW/W9C/Ys/HYSu8
 tsXdtiySy9xYXwkoyk88rFYvklaQWqiXSpiVO5nXftXFSPfYEZglFvX8VWOdNgiepfBYR1cq2
 qXzahnsoluslhvN0eq3DLbsb3DDqea+IABLKm4+kNkx3aFBmzBnbnwdM/KIA1HlnDZz1p3gdi
 hja56Y3pYJzPEVOoMB0qaIrlxiNRiuT1kawwcQNGeooBPExG5KbhxkMRAOde567T2YBFdbmH2
 t2aQZcXNBCPOsNB++7b0dxGWS1PRnFV+961QnNrIvz0oWHMNcIgbYOU18WhAQrX2LUsp9SRhD
 +L+Rvbqa92pRYRapqh+OCkYWUPmPe64HlqXu7QJxav03q6NSMjoziuu7bKnln4yRfRTvGtDT3
 96QR9GYFCg6JQpf48k0IMJl1MpOXnHWeceIbPX1up+4tOu/fKsMrxZNYpGOXSb0TYEW4+eBvZ
 fqzeC7gadxa5XtqV8fgFLLS9hsM/CtVJvmVnIaFgtsEHDKKm98JZ02v3Q2gHgmsk7bLuPzPwP
 NILlh8oVNyLUM5rfVUToQi6OSq0DkbsGGg4EnKfqZh062XxUyyn/omW3CU5Q4TEgmmgRNF8iW
 bzzzE0ylFEv+r2yH0dgI0nQ7LTxbuIwaYqDOHMNUwg9cmT3+F7N0ZdrfIHaQrkHE2L1DSVV4e
 Xpfh0qpvUcR8BcOTdmxyblJg3nTnADO1ccVI10oRyeU2UrB1fytxLm2ofNzKFTmQEq6ivOIDB
 COwZR15b9Nz2SeGuBnuk3Mdb7LmIMnh6zFyHOtu+eVA5HPTnJBiqjHngu7AhbkR/VMD0FRaNL
 FpAaGPg8GqjHj9yVZ4mjf3di/xA=
Precedence: bulk


--kPTYGsB/x7M2pU5I
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 03, 2023 at 06:30:47AM +0000, Nick Terrell wrote:
> On Jan 29, 2023, at 5:14 AM, Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.=
net> wrote:
> >=20
> > assert(x) should emit a warning if x is false. WARN_ON(x) emits a
> > warning if x is true. Thus, assert(x) should be defined as WARN_ON(!x)
> > rather than WARN_ON(x).
> >=20
> > Signed-off-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
>=20
> Hi Jonathan,
>=20
> I have to apologize, I just submitted my branch for a PR and I realize th=
at
> while I intended to take your patch, I took a different equivalent patch.=
 So
> I wanted to say thanks for sending the patch!

No problem at all, and thanks for informing me!

>=20
> > ---
> >=20
> > Commit e0c1b49f5b674 ("lib: zstd: Upgrade to latest upstream zstd
> > version 1.4.10") mentions that the zstd code was generated from the
> > upstream version of zstd, so perhaps the definition of assert based on
> > WARN_ON should be fixed in the conversion script and/or upstream zstd
> > source code.
>=20
> Yeah, we need to fix it upstream, so if you would like to submit the upst=
ream PR
> the file is contrib/linux-kernel/zstd_deps.h [0]. Otherwise, I will updat=
e it before
> the next import.

Feel free to do it yourself, as I haven't been involed with zstd
developement so far.


Thanks,
Jonathan

--kPTYGsB/x7M2pU5I
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmQCA6IACgkQCDBEmo7z
X9uvHRAA0A7DlV6QqMBFvRRplfmwXj7kogLk8ffIJW09hNtGQRPBuGoa0JrSQyjj
viStpP9AkF8OHcbABeGQxMe+ywTBvLLK6iqMv/VN7+qNFoItRhyIA6WK3v3N22km
FduWgptSJBwfNDAwKBTn+g01JHr0eZ9dyJXTTwNCKCeJL0aztPnbr04q5/+A7v9K
gwbwtGUKNA+nk2xAvSIALyNbBwl9JmVPi4VKE2nUqq5fzZgv0DzeFeTOwusij5zY
aixfQ0HmpmgQlEjvvsn7AdVyRCckDH75RfXlGK1sLu8EA/rc+kVYJ8kXJnF6DPri
1hm+G7OFMTFcnMdSRLd2dsmOflSlD0SSu5Ck95heubLnNmkz5V00kl5wpJ/qPYxN
mxR7pWAscpzT80jdOj2KNNmBPc+XsayECF9Ps2xByfkD4UYLOenLAxy7KmFjogjG
vXky5wOElg0MMkj2vcmQj2fwZ7KDbnkecBGTYkcEybtg+TlMVsy0qmtsnjg1E9qE
V3reLAKhQNyOuVM72uLD8u6AMNVwG5ph8zbiiPbvE4Yn0zdIjeEzRg20oPf5/TY+
Zl+FTWO7EG4oTVNPTnw1V4bhfo8o7nUWS3Wk1pPPdBj5CcxTV3WoiTzyZ/UrG8TV
O/jHm+gNB8py4qj85qSnsAVNNCWc33TqontWZPU8v552ubYVsGQ=
=/l8b
-----END PGP SIGNATURE-----

--kPTYGsB/x7M2pU5I--