MIME-Version: 1.0
References: <20230228221533.3240520-1-trix@redhat.com>
In-Reply-To: <20230228221533.3240520-1-trix@redhat.com>
From:   Karol Herbst <kherbst@redhat.com>
Date:   Fri, 3 Mar 2023 15:33:31 +0100
Message-ID: <CACO55tvJH=VmTf+Wv4Lf56eEPp3vO1Aoa6Sb1=UYnRzFkVardg@mail.gmail.com>
Subject: Re: [PATCH] drm/nouveau/fifo: set nvkm_engn_cgrp_get
 storage-class-specifier to static
To:     Tom Rix <trix@redhat.com>
Cc:     bskeggs@redhat.com, lyude@redhat.com, airlied@gmail.com,
        daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Reviewed-by: Karol Herbst <kherbst@redhat.com>

will push in a moment

On Tue, Feb 28, 2023 at 11:15 PM Tom Rix <trix@redhat.com> wrote:
>
> smatch reports
> drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:33:18:
>   warning: symbol 'nvkm_engn_cgrp_get' was not declared. Should it be static?
>
> nvkm_engn_cgrp_get is only used in runl.c, so it should be static
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
> index b5836cbc29aa..93d628d7d508 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
> @@ -30,7 +30,7 @@
>  #include <subdev/timer.h>
>  #include <subdev/top.h>
>
> -struct nvkm_cgrp *
> +static struct nvkm_cgrp *
>  nvkm_engn_cgrp_get(struct nvkm_engn *engn, unsigned long *pirqflags)
>  {
>         struct nvkm_cgrp *cgrp = NULL;
> --
> 2.27.0
>