Message-ID: <f29ae960-dea1-6754-3957-412e3c4d095c@intel.com>
Date:   Fri, 3 Mar 2023 16:35:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] qede: remove linux/version.h
Content-Language: en-US
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>
CC:     Ariel Elior <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, <kernel@collabora.com>,
        <kernel-janitors@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230303125844.2050449-1-usama.anjum@collabora.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230303125844.2050449-1-usama.anjum@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFlTZnVDMDJNTGhkcmtqZEk0eVVuaEQ3UW90ZC9YbnR6ajdGcURFelJVK01X?=
 =?utf-8?B?V0tURDFIUFc0T1graHlORG1FVDlvaGZVSzVnM24vUnhlc2crNm02M2FlN1h1?=
 =?utf-8?B?ZFlIV2oxcDdyL3hobWlBcEFoQXNCdjlOS29ab2tialcxRnJ4aFFvV0pvMkVJ?=
 =?utf-8?B?ekg0aHBlQm5PbytZMXFGMlpQRWtyaHY0N2pDMTRlV1hua05BeEcyQzN4S3RB?=
 =?utf-8?B?Y1EwcVdrV21hbFZvbEQ1ckNvTHRWaCtNV0MwbGtEOHNjenJKbTFXaXRjSU0w?=
 =?utf-8?B?bU1DK1JlbVJJWE96Ly9EWERCS1k1Z2xkbUlUY2tJNFp4cVRQcWMzV1ZqRDZU?=
 =?utf-8?B?S0ZWVUcvYllNdUQyaVQ5bGhHYVkyeGFqRFVWN1J5L05XSkFlZ1dSQVV3OGdD?=
 =?utf-8?B?cWFRYlBJcGVSUUlxKzJwc1Y4YkxXdkN2UjdYYVlxQVhOTGhLOGZNYjAwWXF3?=
 =?utf-8?B?a1BIMlZxcDVBaWZUcVFybXlmSHpYUGlCUTUrYWtHbWV5a3VEWm5IckJPN1dP?=
 =?utf-8?B?Mk9nM01GVG9BZkYyNkhoTEhxclFJWEx2ZklKclppUGMwa3pHMStwbDRNaFZ2?=
 =?utf-8?B?Vm5YajdjNVhCUzlTYmdZM2FENGc5QTI3NkpPZEN1MHh2a05UbXhjTFBnSG5t?=
 =?utf-8?B?Vnllaitpa29qcDBLZUlKM1hHMEVIaWNZVVhrWDY5dDZxb3c0aVZjc29VZUV3?=
 =?utf-8?B?VmdjdlZnNmd6a0JYUzhaZlpMMlc5OFV4NUtJRmFWTHg0dk9YMGNuek96ZHFF?=
 =?utf-8?B?b0hTalBqam1wSUJqbW4zR2J0OWpKV0NVT2NVQk1ndGtlMjJ3ZnptSi96Zk9F?=
 =?utf-8?B?Z0NiVXJhV21sZ2w4Sno2MGdUV2RKbU5MMEsrb0VaaW5CcENiZStseWNBSi9T?=
 =?utf-8?B?aXdZbVUrYVhjYnJTbVFobjZMY2t0bklyb3FRRkdUT1VmTjZxenNrbVBRaU9W?=
 =?utf-8?B?TXp4Vi81eGdmMHBGejNvUFY1R2xKS29pMXFFVkttbVczam5PekRLSXozUDRx?=
 =?utf-8?B?UjZqVnRIYXpzeTRsVkZwRzBqTzVWSUtDTS9lakZQVTlUeUtjL3JCY1FLdjFl?=
 =?utf-8?B?dkVtam1SbEhUTzlDZFZOQlZwSWR5RnVBSFAwbEduQkZGdjF3dmhObi80NzBl?=
 =?utf-8?B?QW5jaE50dHA0aHlQKzBUQ0RIbDBzb0Y4ZmR2bUMzcTFod29PTXlCZlRqdW5U?=
 =?utf-8?B?TmtVblNsVGp2NTVCNE1tdW94Ykx0a1JoZGpldEZzQmpkdVpFbkRGTGhDakVY?=
 =?utf-8?B?Vkp4VTJyVUtpVVNOMDFjT2wwL3BQL0dMSy9ZREJNSkhEdGJjRWlVSytaeWJE?=
 =?utf-8?B?ZG5JcVRXYktZajN5dWxObmh3Vzh1dXJFcjlQN0hnL0VJY1pwWFRPNEtBK3Z1?=
 =?utf-8?B?eXZPMjJNMnJxZzI5Y01Wb0NGendaNm9xa1JJcTRFTERRcTVoRTM0NE9pMEFY?=
 =?utf-8?B?YzhDU0FuUzJOd0FicFBkT0tsWTMzZVFsNWxaMm10cWpDMzZFVU5LemtGczBM?=
 =?utf-8?B?a2ttTjk4TzAyK0NyVVhpdG9zOExWZlNweEtoczI2OW5LMmVvdXhrTnplVmxo?=
 =?utf-8?B?bkpGM3AwOVRpMExKRnpReTl5YitpVEtzMlpEM2ZvVjZ4YkI4RHdlSFZteEdp?=
 =?utf-8?B?V2RSYkhNUGlTSDJReWhDV2lwUEJMRkxJK0I0Slc1dGp3Q1ltbEpsa3A3YnNC?=
 =?utf-8?B?TktYZVBJN1Qwc21DQXJuemVFSCs5dXVGY2NZa0ExbDFzZTg4eTAwb2JoVXJB?=
 =?utf-8?B?d3gxUEY5VFIxZy9XVkh6eUZUMFc0MlhiNXdYdDUyRDFwYnYzYzllMDlZSTR2?=
 =?utf-8?B?STJxeXAvMjRjc054YXlXeDgvUU01TUZLcVVuemxYblB6TXVqT3NLdXo5dVVW?=
 =?utf-8?B?Zy8wVGlQNDF0MG1ray94VldtcVVXNnNycW9EeERnaHJPbG1GZ2kwS1NOUVBl?=
 =?utf-8?B?Q3hjbGpqWG1QR0ZlenNGV1Q5dmtZaXVrTmNFVitUc3BJUXB6VDVTNHFUOENT?=
 =?utf-8?B?RUNUdEh2RGhUc3ZqUHVaWEF1S24zUVJYTC9BZE13NksxZkkrQjJQeW9yRFl0?=
 =?utf-8?B?aDdTQlB5NldCRGhPa0FINXpIM011QW1MbkFJZ2RCdVZCVVpVVENia2ZuK3NW?=
 =?utf-8?B?ZnZxY3ZPUXhPWFlTUHJzOVgrNUZlaW0xcit0ZUFTMkhyQ0NjZG5IMzNpUTJ0?=
 =?utf-8?Q?tAsipfyDFN3CTRpen5wypqk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f327cac8-e49b-4e50-1d79-08db1bfd0eef
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 15:36:29.7096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sh1REVlRfxmJ+2cOzTL9EBqNJUTuElVyFfOtzvhLxHKK9E0Tv2Ql57igLnwjoAUh+iy0WvUTEN1Bz3cTUcr6x7fchsz7BkJXWjE7Ey6i69c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5872
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Muhammad Usama Anjum <usama.anjum@collabora.com>
Date: Fri,  3 Mar 2023 17:58:44 +0500

> make versioncheck reports the following:
> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
> 
> So remove linux/version.h from both of these files.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  drivers/net/ethernet/qlogic/qede/qede.h         | 1 -
>  drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
> index f90dcfe9ee68..6ff1bd48d2aa 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede.h
> +++ b/drivers/net/ethernet/qlogic/qede/qede.h
> @@ -7,7 +7,6 @@
>  #ifndef _QEDE_H_
>  #define _QEDE_H_
>  #include <linux/compiler.h>

I think compiler.h is also unused, maybe this one too, while at it?

> -#include <linux/version.h>
>  #include <linux/workqueue.h>
>  #include <linux/netdevice.h>
>  #include <linux/interrupt.h>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> index 8034d812d5a0..374a86b875a3 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> @@ -4,7 +4,6 @@
>   * Copyright (c) 2019-2020 Marvell International Ltd.
>   */
>  
> -#include <linux/version.h>
>  #include <linux/types.h>
>  #include <linux/netdevice.h>
>  #include <linux/etherdevice.h>

Thanks,
Olek