Date:   Fri, 3 Mar 2023 07:45:49 -0800
From:   Zach O'Keefe <zokeefe@google.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     David Stevens <stevensd@chromium.org>, linux-mm@kvack.org,
        Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Yang Shi <shy828301@gmail.com>,
        David Hildenbrand <david@redhat.com>,
        Hugh Dickins <hughd@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] mm/khugepaged: fix khugepaged+shmem races
Message-ID: <20230303154549.xli4knfliv4c7gc4@google.com>
References: <20230217085439.2826375-1-stevensd@google.com>
 <ZAIT2YI4WrzZK5NK@x1n>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZAIT2YI4WrzZK5NK@x1n>
Precedence: bulk

On Mar 03 10:35, Peter Xu wrote:
> On Fri, Feb 17, 2023 at 05:54:36PM +0900, David Stevens wrote:
> > From: David Stevens <stevensd@chromium.org>
> > 
> > Fix two races in khugepaged+shmem that cause issues with userfaultfd and
> > lseek, respectively.
> > 
> > v3 -> v4:
> >  - Base changes on mm-everything (fba720cb4dc0)
> >  - Add patch to refactor error handling control flow in collapse_file
> >  - Rebase userfaultfd patch with no significant logic changes
> >  - Different approach for fixing lseek race
> 
> I just noticed this one hasn't landed unstable, so I guess I just posted a
> trivial cleanup that can conflict with this so it won't apply cleanly..
> 
> https://lore.kernel.org/r/20230303151218.311015-1-peterx@redhat.com
> 
> The resolution will be fairly straightforward though, and I'm happy to
> rebase that one to this since this targets a real bug so should have higher
> priority.
> 
> I guess it's possible Andrew thought the series has unsettled comment so
> Andrew could just have ignored that whole set in the mark ups.  A repost
> could possibly clarify that.
> 
> Again, it'll always great to get another eye on this slightly involved
> series. Matthew / Yang were already on the list, also copying Zach for his
> recent works on khugepaged just in case he spots anything wrong.

Thanks Peter. My email filters need some tinkering, since I missed this until
yesterday when I came across it by chance. Thanks for Cc'ing me. I'm taking a
look now, and likewise will if reposted.

Best,
Zach

> 
> Thanks,
> 
> -- 
> Peter Xu
>