Message-ID: <79d4f0ad-c014-6b9f-4c0e-c71163457b30@quicinc.com>
Date:   Fri, 3 Mar 2023 23:02:46 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] ASoC: codecs: tx-macro: Fix for KASAN: slab-out-of-bounds
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC:     Banajit Goswami <bgoswami@quicinc.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        "moderated list:QCOM AUDIO (ASoC) DRIVERS" 
        <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20230303125717.29196-1-quic_visr@quicinc.com>
 <73ea5ba2-18c8-abd8-3896-eb9656201f53@linaro.org>
From:   VISHNUVARDHAN RAO RAVULAPATI <quic_visr@quicinc.com>
In-Reply-To: <73ea5ba2-18c8-abd8-3896-eb9656201f53@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 3/3/2023 7:45 PM, Srinivas Kandagatla wrote:
>
>
> On 03/03/2023 12:57, Ravulapati Vishnu Vardhan Rao wrote:
>> @@ -1064,9 +1064,10 @@ static int tx_macro_hw_params(struct 
>> snd_pcm_substream *substream,
>>                     struct snd_soc_dai *dai)
>>   {
>>       struct snd_soc_component *component = dai->component;
>> -    u32 decimator, sample_rate;
>> +    u32 sample_rate;
>>       int tx_fs_rate;
>>       struct tx_macro *tx = snd_soc_component_get_drvdata(component);
>> +    u8 decimator = 0;
> Minor nit, any reason why decimator is intialized as part of this change.
>
> --srini
Will Remove that..Thanks for review