Message-ID: <2111304e-6a22-e767-f79b-c72cde42294b@ddn.com>
Date:   Fri, 3 Mar 2023 19:26:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [RFC PATCH 5/9] fuse: move fuse connection flags to the separate
 structure
To:     Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>,
        mszeredi@redhat.com
Cc:     Al Viro <viro@zeniv.linux.org.uk>,
        Amir Goldstein <amir73il@gmail.com>,
        =?UTF-8?Q?St=c3=a9phane_Graber?= <stgraber@ubuntu.com>,
        Seth Forshee <sforshee@kernel.org>,
        Christian Brauner <brauner@kernel.org>,
        Andrei Vagin <avagin@gmail.com>,
        Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        criu@openvz.org
References: <20230220193754.470330-1-aleksandr.mikhalitsyn@canonical.com>
 <20230220193754.470330-6-aleksandr.mikhalitsyn@canonical.com>
Content-Language: en-US
From:   Bernd Schubert <bschubert@ddn.com>
In-Reply-To: <20230220193754.470330-6-aleksandr.mikhalitsyn@canonical.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnB2SkdxVTF6RndQMnp1TTJNSmxEajB3N3NmZWVUeFFydXZaaG9vMjFyWlNL?=
 =?utf-8?B?YkMzRzQwQ3RSMk9xMG9FUmtiTmFCdGp6cStzWWlpODA1b0llSjR1L0RiRFcx?=
 =?utf-8?B?UExQUThKTjVTQnhQdzJCNllRQWhvWFoyQmRyOGtiMTh3bGtRQVgzcWZvb0FQ?=
 =?utf-8?B?bkVrZVhUQlZLUzJYZXRxQk9VNnlEUk5qWTlPeVlrT295VWh3MTVxd2kvVnBt?=
 =?utf-8?B?NVBQUVFyb3VhRjhSMXNBQWp3dkJRWkdrNlpRMzd6ZFkvTHI0RkRBaEVLUElx?=
 =?utf-8?B?ek5BK1NHWUtlZ1JLMDhtVUR3eGt5NExTbzFyUzJWWjV3cDgwVDJ0SlJmQU91?=
 =?utf-8?B?eHF1NndGMWFSSnFEbXRTdkptVmtVRnNzZ0dKMVNjRytIKzNWakpkaEtLVDFF?=
 =?utf-8?B?VU9ZN0hYdWNZWlhFdjU5VFRmSnhKcEpaTC80dlJMMGZvdzFBdlVLRjNMVlZE?=
 =?utf-8?B?bHBrUGNGTUpwa0Jmcm1KZVM3SkR5RytyaDR5MFgydmVLanpjS1Y5MzljZGdM?=
 =?utf-8?B?cFMyV1liWUhUYTQ1ZC9YQ3ZsVUt2UWlUMFJBbGMrMUYzZzNJM21uUU56Y3Jw?=
 =?utf-8?B?cjlBS2hXcUhDTlNZSlh1OXRaUE04d2ZEYXA3aE40cUtpQlJINSs5YlpDTmJ0?=
 =?utf-8?B?b0NqZFVxdyt2aU52VDNMZ0VScmtrM0pNVVdEZ3h3dkk1OWdjZTBrWkdBKzRu?=
 =?utf-8?B?V2lRcHpqcGhWaFVRSHFJZTN6K0NUVnhidzhzbjAyM2FZWkJaYk9CcXpLdWx4?=
 =?utf-8?B?L1ZpaFdraWZWalJWMjVpZGVseWtQN2NaOHpSU00wTnVHQzd3eUZvOXNGaHdi?=
 =?utf-8?B?SFZNdkh1OGFVUkh6Y1pQWWJZL2p2OXlxWjZmdHFTbEk4WStkb0R1TnNnK0tt?=
 =?utf-8?B?M2x6T25aeWw3TzJSM1ZoRGg5b2hrWENScHlsWG9oOEtnUGZ3NnBLRFlmL0ZH?=
 =?utf-8?B?WmwrcURnaVhmQk9DRFloMVZSYUEyOTQ5ZW95cFJvRy9mWEVQelcxcVpBZE9K?=
 =?utf-8?B?ajhJK1NuVzc2Tm1YbXRVNGQzckk1TXcyaEZUTVZQTnhWUkRuOHk2NWs4UVU5?=
 =?utf-8?B?TEZPbjVjcGdrUnd3VGdWTjBJZ3ZaRTFGTmlCc1g3UTdhU1ZTZlNZQWJlRlBC?=
 =?utf-8?B?anl4L2s4K2tHaDBWajdNZ2dnNFZlaXQ5UDdDY0syTUNadE1SQ1o3L3oyQlB5?=
 =?utf-8?B?WU9GVExVNS8raW9RbTJaTXVYSmIzNlJvQ1RKQVJER0pIRkNaa1RienJXT1VY?=
 =?utf-8?B?bWplc2ViVlpHeWNZaDRCd0pLZE1RU3FpRzVGYmFMVkw2bnpEQzMrN2tJT2lS?=
 =?utf-8?B?N3liZEZ6NFRoYkJkTWUxK1JuTnZiOUkvTGZCMENURzRwSXZENGlXeU5hMDFC?=
 =?utf-8?B?ZFVyUDloMFU3NmdiVUtMc0RJUWZiNkl3NlBUd0IzcExtRU53cmJNU0l0VU9T?=
 =?utf-8?B?UXNzZTFXK3p6ZkpJNUNQZ0F5Um4xYjl3bUFRZkkyVkRYYzkyYXpFYngySW04?=
 =?utf-8?B?VE82TkpkWHQzeTY2NDhTYlJlQm5tR0U3bWNvbUJtTEdKMnEvUWhVUXNoVkl2?=
 =?utf-8?B?UFlFMVVEaThZSzF4S3d6ajdtSlFYTm4rZnphUFpROEpEUUZ2NXM0Yk9TclV1?=
 =?utf-8?B?U3UyK1JhTENlYTRPMnRxZldtQkZQZ2tZU3UzUGFHVzlYNys5aU1FZVZOY2Nk?=
 =?utf-8?B?MVd3c2pIQ3loSGxJc2ZTQ1p0ekJzY3E4dER1d05Na2x1WU5kR3RIaGt1aldX?=
 =?utf-8?B?ODBOdTNLZit6Rkx1L1Rnc2taeS90U0hGOG83bVR6LzBXQm85amp1SXRqY0Nv?=
 =?utf-8?B?d1A3TXBWcmVVVjE3MW8yK1d2ZWxuWkIzVy8ySHdMSGlLMjVQRWovd2xWdWdC?=
 =?utf-8?B?UHM0S05xNWxRUXM0NHU1MCs4cUs2Q21FYmJOdE1lQXRqVnllZUp3ekNtYVZL?=
 =?utf-8?B?MFVxb3JQREdJQmFqKzJHdzlBRVMxN1lka2lCMEtzSmJQaWRodXhocDJ1NUFG?=
 =?utf-8?B?WWljSVF3bkhKZDRYa3hsaXJlMzdqWi92ckMxUitKL3BqdEFkYXZQYWpXYnE3?=
 =?utf-8?B?SEZmNGhVNUxBdnJ0enhleUdSdEtSbGVuRzJ1d2p1dW1XTTRML1JyYUpBM3l5?=
 =?utf-8?Q?R7chjMhFstNJtjG65WQJwnCbF?=
X-OriginatorOrg: ddn.com
X-MS-Exchange-CrossTenant-Network-Message-Id: baa4b04b-88a4-4a95-9915-08db1c14de22
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1901MB2037.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 18:26:56.0571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 753b6e26-6fd3-43e6-8248-3f1735d59bb4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tSMKp/gMdbBM8XrhGGKue7AKJUpBkvte13wnvKJZD6SGyJ44eb+jNJR5tvsrsnwrgFGGgDg5y4m1UGIOC0ukNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR19MB4214
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/20/23 20:37, Alexander Mikhalitsyn wrote:
> Let's move all the fuse connection flags that can be safely zeroed
> after connection reinitialization to the separate structure fuse_conn_flags.
> 
> All of these flags values are calculated dynamically basing on
> the userspace daemon capabilities (like no_open, no_flush) or on the
> response for FUSE_INIT request.
> 

 From my point of view this makes the code a bit better readable, in 
general.

[...]

>   };
>   
> +/**
> + * A Fuse connection.
> + *
> + * This structure is created, when the root filesystem is mounted, and
> + * is destroyed, when the client device is closed and the last
> + * fuse_mount is destroyed.
> + */
> +struct fuse_conn_flags {
> +	/** Do readahead asynchronously?  Only set in INIT */
> +	unsigned async_read:1;


The comment does not match the struct?