MIME-Version: 1.0
References: <20230121112947.53433-1-robimarko@gmail.com> <20230121112947.53433-4-robimarko@gmail.com>
 <d71e8a18-8a09-c722-d9dd-b2d48615828f@linaro.org> <CAA8EJppwNVtUjB7fUZSCrZ88Ssbhmc4HD6oA2nV0uEx+vHBXUw@mail.gmail.com>
 <2a7a43f1-a13d-f094-5167-de74d5092d91@linaro.org>
In-Reply-To: <2a7a43f1-a13d-f094-5167-de74d5092d91@linaro.org>
From:   Robert Marko <robimarko@gmail.com>
Date:   Fri, 3 Mar 2023 19:38:43 +0100
Message-ID: <CAOX2RU6vociXPTQE4tegQE8YXjHgQAHgdQWm3N9PPekgaw3ung@mail.gmail.com>
Subject: Re: [PATCH 4/4] cpufreq: qcom-nvmem: make qcom_cpufreq_get_msm_id()
 return the SoC ID
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        ilia.lin@kernel.org, agross@kernel.org, andersson@kernel.org,
        rafael@kernel.org, viresh.kumar@linaro.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 18 Feb 2023 at 21:40, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 18.02.2023 21:36, Dmitry Baryshkov wrote:
> > On Sat, 18 Feb 2023 at 16:43, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> >>
> >>
> >>
> >> On 21.01.2023 12:29, Robert Marko wrote:
> >>> Currently, qcom_cpufreq_get_msm_id() does not simply return the SoC ID
> >>> after getting it via SMEM call but instead uses an enum to encode the
> >>> matched SMEM ID to 2 variants of MSM8996 which are then used in
> >>> qcom_cpufreq_kryo_name_version() to set the supported version.
> >>>
> >>> This prevents qcom_cpufreq_get_msm_id() from being universal and its doing
> >>> more than its name suggests, so lets make it just return the SoC ID
> >>> directly which allows matching directly on the SoC ID and removes the need
> >>> for msm8996_version enum which simplifies the driver.
> >>> It also allows reusing the qcom_cpufreq_get_msm_id() for new SoC-s.
> >>>
> >>> Signed-off-by: Robert Marko <robimarko@gmail.com>
> >>> ---
> >>>  drivers/cpufreq/qcom-cpufreq-nvmem.c | 44 ++++++++--------------------
> >>>  1 file changed, 12 insertions(+), 32 deletions(-)
> >>>
> >>> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> >>> index da55d2e1925a..9deaf9521d6d 100644
> >>> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
> >>> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> >>> @@ -32,12 +32,6 @@
> >>>
> >>>  #include <dt-bindings/arm/qcom,ids.h>
> >>>
> >>> -enum _msm8996_version {
> >>> -     MSM8996_V3,
> >>> -     MSM8996_SG,
> >>> -     NUM_OF_MSM8996_VERSIONS,
> >>> -};
> >>> -
> >>>  struct qcom_cpufreq_drv;
> >>>
> >>>  struct qcom_cpufreq_match_data {
> >>> @@ -134,30 +128,16 @@ static void get_krait_bin_format_b(struct device *cpu_dev,
> >>>       dev_dbg(cpu_dev, "PVS version: %d\n", *pvs_ver);
> >>>  }
> >>>
> >>> -static enum _msm8996_version qcom_cpufreq_get_msm_id(void)
> >>> +static int qcom_cpufreq_get_msm_id(void)
> >> This should be u32 as info->id is __le32

Nice catch.


> >>
> >> And please export this function from socinfo, it'll come in
> >> useful for other drivers!

I intentionally did not do that as socinfo is currently fully optional
and I dont really like
the idea of making it required for anything using SMEM.

Regards,
Robert

>
> Konrad
> >