MIME-Version: 1.0
References: <20230303182922.3903229-1-kumaravel.thiagarajan@microchip.com>
In-Reply-To: <20230303182922.3903229-1-kumaravel.thiagarajan@microchip.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 3 Mar 2023 19:45:33 +0100
Message-ID: <CAMuHMdXvwGzyDTUA=E5=pvGhR4xaBj75OkeU7jr651j6B7kBzA@mail.gmail.com>
Subject: Re: [PATCH v1 tty-next] serial: 8250_pci1xxxx: Disable
 SERIAL_8250_PCI1XXXX config by default
To:     Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        andriy.shevchenko@linux.intel.com, deller@gmx.de,
        geert+renesas@glider.be, matthew.gerlach@linux.intel.com,
        phil.edworthy@renesas.com, UNGLinuxDriver@microchip.com,
        Linus Torvalds <torvalds@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, Mar 3, 2023 at 7:29 PM Kumaravel Thiagarajan
<kumaravel.thiagarajan@microchip.com> wrote:
> Commit 32bb477fa7bf ("serial: 8250_pci1xxxx: Add driver for quad-uart
> support") made the SERIAL_8250_PCI1XXXX driver enabled when SERIAL_8250
> is enabled, disable it as this driver need not be enabled by default

does not need to be enabled

>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Link: https://lore.kernel.org/lkml/CAHk-=whhFCeeuo6vTEmNSx6S-KKkugxgzN_W5Z6v-9yH9gc3Zw@mail.gmail.com/
> Fixes: 32bb477fa7bf ("serial: 8250_pci1xxxx: Add driver for quad-uart support")
>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> ---
> v0 -> v1:
> - Add proper commit description

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds