Message-ID: <5194a1be-73d1-bbc1-879f-bec8353663bc@linuxfoundation.org>
Date:   Fri, 3 Mar 2023 13:42:41 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] selftests: ir: add config file
Content-Language: en-US
To:     Anders Roxell <anders.roxell@linaro.org>, shuah@kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20230221070301.1323044-1-anders.roxell@linaro.org>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20230221070301.1323044-1-anders.roxell@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/21/23 00:03, Anders Roxell wrote:
> Building and running the subsuite 'ir' of kselftest, shows the
> following issues:
>   ir_loopback: module rc-loopback is not found in /lib/modules/6.2.0-rc8-next-20230220 [SKIP]
> 

Why is this an issue? I am not saying this patch isn't necessary.
But the behavior above is valid behavior when config options
aren't enabled?

Perhaps the commit log could reflect that adding config file
with the right options allows the test to run as opposed to
describing a valid behavior is an issue.

> By creating a config file with RC_LOOPBACK=m, LIRC=y and a few
> IR_*DECODER=m in the selftests/ir/ directory the tests pass.
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>   tools/testing/selftests/ir/config | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>   create mode 100644 tools/testing/selftests/ir/config
> 
> diff --git a/tools/testing/selftests/ir/config b/tools/testing/selftests/ir/config
> new file mode 100644
> index 000000000000..a6031914fa3d
> --- /dev/null
> +++ b/tools/testing/selftests/ir/config
> @@ -0,0 +1,13 @@
> +CONFIG_LIRC=y
> +CONFIG_IR_IMON_DECODER=m
> +CONFIG_IR_JVC_DECODER=m
> +CONFIG_IR_MCE_KBD_DECODER=m
> +CONFIG_IR_NEC_DECODER=m
> +CONFIG_IR_RC5_DECODER=m
> +CONFIG_IR_RC6_DECODER=m
> +CONFIG_IR_RCMM_DECODER=m
> +CONFIG_IR_SANYO_DECODER=m
> +CONFIG_IR_SHARP_DECODER=m
> +CONFIG_IR_SONY_DECODER=m
> +CONFIG_IR_XMP_DECODER=m
> +CONFIG_RC_LOOPBACK=m

thanks,
-- Shuah