Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C15CC7EE32 for ; Fri, 3 Mar 2023 20:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231708AbjCCU4p (ORCPT ); Fri, 3 Mar 2023 15:56:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231415AbjCCU4n (ORCPT ); Fri, 3 Mar 2023 15:56:43 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D621F168A4; Fri, 3 Mar 2023 12:56:42 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id qa18-20020a17090b4fd200b0023750b675f5so7399559pjb.3; Fri, 03 Mar 2023 12:56:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677877002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=fjh9IEpIRyNQHewWnw6H4mE9vVwZa4PIB3habustRYM=; b=YcOgEPLI7Pxk40hWD3Mrc61wy5H7d33RmImy1dSuT0n4jGUj8+bCu3IGc/pduDoDNP D1qe5VQ7yxuzuyqc3/evqmE8QqXcgX0OVNLrCQARJcIhlNXePr0f5m+RdBIjuxKmxgAE Ny1FrXP+3lDFuxJrmwArqa5MNDU8AL80bYRhAHPKZN9yKxNUEG2/XnbPi2uMjuAouwim 7QGe7PZoVhz2SMwK3BOoiE9ORtcdrHAumSQzzZM4SFcycRnJSbsy+7Wu+fxpSIfTlTO+ tynTtNrbxYrXe9PVRjftdClTEsLfEsILK7GlAllCaveqepfzveMDwsDP8XuqDt2KTIqL 3j1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677877002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fjh9IEpIRyNQHewWnw6H4mE9vVwZa4PIB3habustRYM=; b=kifLUyy6mcGIzbEBT1V7jsS7wdJdhrKUy5XYALaCZsMtcEo4/mlru0ojJUzE32ELnG TULns5O3oCXE7KoSgZSrSUOu99f/kyGOIeBNFayFXxOmfno+eN3ary8m9CdMTMQjdSpn pBcFWmcoQsXTaBfpwJua979hzMtn669KghRU3wW+7nsJRtoCjaDAubXixmlFp02NChAG xR7jcB1Vv+a+dFvKm7idHIjwLTKkiifFJ291Vpy79l9hEx3kn/f4yqdztC4P8Lc6ZEXU 7WLF/RcpCgZloTMWiOyfjo0N6LwkO+ZSGnyooiL8Pnz3szlTbnK+ZI0Mwtl6eZPZj1Y2 cePw== X-Gm-Message-State: AO0yUKXaJrY3z+GFpQeN+fUxpgmQnnfPFrcIuCsZuCgi8ETDgSYmnYCL ElKCw765WMHycP9E+IuW7fwodX0t5A8= X-Google-Smtp-Source: AK7set8Rg7RDKbeAplxt/7+7Tu1q5BB6FaMGpY1vkp+vH9xvZF1xovUA3JORx0AXBDPevem23XuVuQ== X-Received: by 2002:a17:90b:3ec2:b0:237:a500:eca6 with SMTP id rm2-20020a17090b3ec200b00237a500eca6mr6953890pjb.22.1677877002138; Fri, 03 Mar 2023 12:56:42 -0800 (PST) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id b4-20020a17090a488400b00230c8484fbfsm1905578pjh.55.2023.03.03.12.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 12:56:41 -0800 (PST) Sender: Tejun Heo Date: Fri, 3 Mar 2023 10:56:39 -1000 From: Tejun Heo To: Kamalesh Babulal , Alexei Starovoitov Cc: Zefan Li , Johannes Weiner , Christian Brauner , Martin KaFai Lau , Tom Hromatka , cgroups@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: bpf: use cgroup_lock()/cgroup_unlock() wrappers Message-ID: References: <20230303095310.238553-1-kamalesh.babulal@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230303095310.238553-1-kamalesh.babulal@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Fri, Mar 03, 2023 at 03:23:10PM +0530, Kamalesh Babulal wrote: > Replace mutex_[un]lock() with cgroup_[un]lock() wrappers to stay > consistent across cgroup core and other subsystem code, while > operating on the cgroup_mutex. cgroup_[un]lock() were added because multi-gen lru wanted to lock cgroup_mutex from code which may be enabled even when cgroup is not enabled. That's the only place where that's the case. Hmm... it doesn't really matter I guess. Yeah, let's do this. Acked-by: Tejun Heo Alexei, if you wanna take it through the bpf tree, please go ahead. Otherwise, I can route it through cgroup tree. Thanks. -- tejun