MIME-Version: 1.0
References: <20230303095310.238553-1-kamalesh.babulal@oracle.com> <ZAJfB/LuHtE5Iq3i@slm.duckdns.org>
In-Reply-To: <ZAJfB/LuHtE5Iq3i@slm.duckdns.org>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Fri, 3 Mar 2023 13:03:20 -0800
Message-ID: <CAADnVQJcKAvhUqJO9HJUQu6BfRw=dN=q+0o3CdhHX0Ei9-waAw@mail.gmail.com>
Subject: Re: [PATCH] cgroup: bpf: use cgroup_lock()/cgroup_unlock() wrappers
To:     Tejun Heo <tj@kernel.org>
Cc:     Kamalesh Babulal <kamalesh.babulal@oracle.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Christian Brauner <brauner@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Tom Hromatka <tom.hromatka@oracle.com>,
        "open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Mar 3, 2023 at 12:56=E2=80=AFPM Tejun Heo <tj@kernel.org> wrote:
>
> Hello,
>
> On Fri, Mar 03, 2023 at 03:23:10PM +0530, Kamalesh Babulal wrote:
> > Replace mutex_[un]lock() with cgroup_[un]lock() wrappers to stay
> > consistent across cgroup core and other subsystem code, while
> > operating on the cgroup_mutex.
>
> cgroup_[un]lock() were added because multi-gen lru wanted to lock
> cgroup_mutex from code which may be enabled even when cgroup is not enabl=
ed.
> That's the only place where that's the case. Hmm... it doesn't really mat=
ter
> I guess. Yeah, let's do this.
>
>   Acked-by: Tejun Heo <tj@kernel.org>
>
> Alexei, if you wanna take it through the bpf tree, please go ahead.
> Otherwise, I can route it through cgroup tree.

Either way is fine. diff stat says that cgroup directory has more changes,
so probably lesser chance of conflicts if it goes through cgroup tree.
So go ahead. Pls add:
Acked-by: Alexei Starovoitov <ast@kernel.org>