Message-ID: <b106b6ea-f1c3-1d47-6851-2e580b885c58@amd.com>
Date:   Fri, 3 Mar 2023 16:11:21 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] drm/amd/display: Simplify same effect if/else blocks
To:     Deepak R Varma <drv@mailo.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Praveen Kumar <kumarpraveen@linux.microsoft.com>,
        Saurabh Singh Sengar <ssengar@microsoft.com>
References: <Y8POxreeC3EvOXhC@ubun2204.myguest.virtualbox.org>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <Y8POxreeC3EvOXhC@ubun2204.myguest.virtualbox.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEtxNThWRUIvUkZOd0RNd2VYdkFGWC96Mmk5Ky85S3J3MEFJdGYrZHRvZ2dH?=
 =?utf-8?B?SnNjeHpPNmJsT2NFTkNDUmVObkE2RXBad1pqSy9qekh2a2RtbVlTdjdGTjRW?=
 =?utf-8?B?OE1leXN4aU5GSlorY1VqZXJFaHJHTEp4L3FhRkpkRDhwYVJ3Qm8xTmFsdDBw?=
 =?utf-8?B?Y3RkUlh2VTRzUitxbW5Rc3ZTb2hKbHFibmVqKy8zTzFadXpiU1hiWkJWY295?=
 =?utf-8?B?WWV2WEtpUWc5eURLSE5TRVc2cG8reVE2S0pxalRqcFZCSk41QjQxRGgrRkUw?=
 =?utf-8?B?aGFmRHdTNUZ1aXZaMm5nSksySmN2YWU2cHBFUjBzS1BaTHF6VDVkT3VkVDU2?=
 =?utf-8?B?cFVDeE9uUEgwekhSYlg0ZWxvSkwzMGllL2tlTkJXQ29kSlJGRDBzWUdLNVl3?=
 =?utf-8?B?WHJhQjh5ek14NVZhdzdxU1JjYmVSRVZ1RHVYS3BjbUN0N3BjT3NQRmhNYVp6?=
 =?utf-8?B?SmRLVk0xWU81VnRQMld4ckVCQXJGQ0t1NkExOHNPSWlXa21NVmtMRFVTVG5s?=
 =?utf-8?B?SUVxU0lqajBnT3hoWHl0V0VQWlhmVlpmd2RVR1IyeExBZ0U0R3ZHTXkvbUp5?=
 =?utf-8?B?R2o0Y1FTdm96OXZZM0pVWHg4SHhxY2sxbnUyQU5BUG1Qc0xFS2I3UXdEbEdY?=
 =?utf-8?B?Z3pDUS9NUDJLMU5iVlVKcmltVmtKU015d0ZjSnNwOEJVVHBmK1pOOWdUSzdl?=
 =?utf-8?B?aU9hY1F0cXI4UnVyYmZWMlQxK2R6aFJRejFnbFpBcW1wdUx2UVk0SWVFL0tX?=
 =?utf-8?B?RUF3Q3dHOHlHQ2ZxbGcrOHNBcFRWQktjTmlBdzlqNmhpa1lOemx4MlpEaVdE?=
 =?utf-8?B?U0ZwRzVjUEFDU3lwcEtFZkx0NWlrRWdkd1M2cjI1WjgwQXdabzYvTkZVS01D?=
 =?utf-8?B?cExXa2V3QytUaEFLdXllTGhSaVM1Ui9YK0E5M3VQK2UyeXZQbVE5R09UUG90?=
 =?utf-8?B?OEhxcHN2VjJOdWY0Qy9LZENhTDhKblQ0Q1RmMHQ4SnlHRHY1c3kvRFpPMDJa?=
 =?utf-8?B?SlNJYTRRTFZsRXdhZFpyREZyOGhkVVJXZ1g0T0NXK2tVMUNlaTFCZHV0Zyt3?=
 =?utf-8?B?a0ZOQnN5bE1hRmJCZ1J0eUhnMWJaVVh5QzR1Smttb2FkWXlLSjV1Vm5kYzNT?=
 =?utf-8?B?TW5TU2hpZkVjazBpT0d2dUZVT0R2QTZPSDBZQm1uWTk5bUxVaUNQd1FCL0Ni?=
 =?utf-8?B?YUprWURicEtFbDVHbEFHWHczV3BUb2hIMGFVTGE5SU1OZHV1QVpOTEtwVmVV?=
 =?utf-8?B?L1dNS2FHQVZSVHg4QjJoQnJZN3JVMDdsU2JlMFVQN3ZNNGFqcW9Hd3RmQU51?=
 =?utf-8?B?R2VDY093T3pSQ0ZDb084RWNTbEdaUHNxb2tqZ0hTUFYycWMwbTl4OTYremVO?=
 =?utf-8?B?WkxDOUFRaGdpWmg4UlRrSUgxNWlmRHlud1p4WFM0MEdWczArRVhlMGs3bDVz?=
 =?utf-8?B?SkdaNFVnb2szQ3BoUnhQdVU3R1EvZ29hZGdTNFJFN3ZDMXpHSlF3eEZZUWc3?=
 =?utf-8?B?NDFZd0kreFFLT1laM2RZWWVabTBUNjF0QmJPeXpiaVBTQTVsVnNyUTgyMFdp?=
 =?utf-8?B?L2NVVkIraDA1ZzlBQmNDWmM5OWgyWXZYV1Q1RkdMazg5TitvL2t3MWlsOGNi?=
 =?utf-8?B?T0NWNHg1cG0xN3FKdGY4UUxJbGw5MHV3RFBGdmpuODV4UGRXNGlUbXlpZDF6?=
 =?utf-8?B?T0huYkNLQXhSL1o1YWEyZE80STZZQnA4MUpNZzd3Uy9scVdJWjhpd0RuS2FK?=
 =?utf-8?B?NjQvU0RwOG9vNjQ0MGYzazJKWmxGWkViYmVwZ1lyczdOelFjYUlWTDFESWlW?=
 =?utf-8?B?TDZMSVgxWVU4TnJBTndmRkg2QjJvWVU0KzJZd0JOWnc3c1FvakJUSkN5K2dz?=
 =?utf-8?B?Z3JnYWl1eVRlcVI0SE9lNEd0ak56Sy9VMlVKZHFhUWYyRkw5U2xSUHlaS0JO?=
 =?utf-8?B?TjIrd2thMHB1ZmEwMFYvVEc0M3gyM0xxMUVUdERReDdsRnlUUS9xcnlsVFIw?=
 =?utf-8?B?MUdDTU1YcGRNN0F0VWZWK0NRekZaR2lQM093UUlnUUN1cUtuR3VaNVF0WGZN?=
 =?utf-8?B?b0ZJTjlxRTNGcVJVNTk2VjIzTXpvQTVIMDllaUg4TmcvTzFKQ2ViUjhKaHNL?=
 =?utf-8?Q?Lx6z0tockf1Ljh3kLuyiNj04n?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68e55f3f-e7ae-4c14-aab3-08db1c2babd6
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2023 21:10:09.7544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vUT3xNeE7px6LsECF8/KoCJc9OndWDnhyWcMBDhvxJXIG+qAhiE6i70EG30YNnRKK4s1pStpGk1WQpz482HuCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4089
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/15/23 05:00, Deepak R Varma wrote:
> The if / else block code has same effect irrespective of the logical
> evaluation.  Hence, simply the implementation by removing the unnecessary
> conditional evaluation. While at it, also fix the long line checkpatch
> complaint. Issue identified using cond_no_effect.cocci Coccinelle
> semantic patch script.
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>

Applied, thanks!

> ---
> Please note: The proposed change is compile tested only. If there are any
> inbuilt test cases that I should run for further verification, I will appreciate
> guidance about it. Thank you.
> 
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 11 +++--------
>   1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 0cb8d1f934d1..776209e5d21f 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3470,14 +3470,9 @@ static void commit_planes_for_stream(struct dc *dc,
>   		/* Since phantom pipe programming is moved to post_unlock_program_front_end,
>   		 * move the SubVP lock to after the phantom pipes have been setup
>   		 */
> -		if (should_lock_all_pipes && dc->hwss.interdependent_update_lock) {
> -			if (dc->hwss.subvp_pipe_control_lock)
> -				dc->hwss.subvp_pipe_control_lock(dc, context, false, should_lock_all_pipes, NULL, subvp_prev_use);
> -		} else {
> -			if (dc->hwss.subvp_pipe_control_lock)
> -				dc->hwss.subvp_pipe_control_lock(dc, context, false, should_lock_all_pipes, NULL, subvp_prev_use);
> -		}
> -
> +		if (dc->hwss.subvp_pipe_control_lock)
> +			dc->hwss.subvp_pipe_control_lock(dc, context, false, should_lock_all_pipes,
> +							 NULL, subvp_prev_use);
>   		return;
>   	}
>   

-- 
Hamza