Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764946AbXIMDzA (ORCPT ); Wed, 12 Sep 2007 23:55:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763205AbXIMDyU (ORCPT ); Wed, 12 Sep 2007 23:54:20 -0400 Received: from mylar.outflux.net ([69.93.193.226]:41663 "EHLO mylar.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762855AbXIMDyT (ORCPT ); Wed, 12 Sep 2007 23:54:19 -0400 Date: Wed, 12 Sep 2007 20:54:07 -0700 From: Kees Cook To: Jeff Garzik Cc: linux-kernel@vger.kernel.org, Ben Collins Subject: Re: [PATCH] usb: fix unterminated usn_device_id lists Message-ID: <20070913035407.GN8183@outflux.net> References: <20070913004709.GL8183@outflux.net> <46E88F1B.5050405@garzik.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46E88F1B.5050405@garzik.org> Organization: Ubuntu X-HELO: gorgon.outflux.net Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 596 Lines: 27 Hi, On Wed, Sep 12, 2007 at 09:15:07PM -0400, Jeff Garzik wrote: >> + { 0, }, > > FWIW I (and several drivers) tend to prefer the more clean version, > > { }, > > or even > > { }, /* terminate list */ Ah, yes. I see that now in some of the other drivers. Should I re-send this patch (and/or the other PCI patches)? Thanks, -Kees -- Kees Cook - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/