MIME-Version: 1.0
References: <20230303120233.1878140-1-usama.anjum@collabora.com>
In-Reply-To: <20230303120233.1878140-1-usama.anjum@collabora.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 3 Mar 2023 16:55:29 -0500
Message-ID: <CADnq5_M_irvEL4Ggr4UaK2n5GeGD_EchqtZvumBtmdOUqqewhQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: remove dead code
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc:     Evan Quan <evan.quan@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, Kun Liu <Kun.Liu2@amd.com>,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        kernel@collabora.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Fri, Mar 3, 2023 at 7:03 AM Muhammad Usama Anjum
<usama.anjum@collabora.com> wrote:
>
> The less than zero comparison of unsigned variable "value" is never
> true. Remove dead code.
>
> Fixes: c3ed0e72c872 ("drm/amdgpu: added a sysfs interface for thermal throttling")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index f212cae0353f..0ffe351c1a1d 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -1738,7 +1738,7 @@ static ssize_t amdgpu_set_apu_thermal_cap(struct device *dev,
>         if (ret)
>                 return ret;
>
> -       if (value < 0 || value > 100) {
> +       if (value > 100) {
>                 dev_err(dev, "Invalid argument !\n");
>                 return -EINVAL;
>         }
> --
> 2.39.2
>