Date:   Fri, 3 Mar 2023 15:28:33 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Yosry Ahmed <yosryahmed@google.com>
Cc:     Sergey Senozhatsky <senozhatsky@chromium.org>,
        Minchan Kim <minchan@kernel.org>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based fullness
 grouping
Message-Id: <20230303152833.24d7a42102bd712e09f95cd5@linux-foundation.org>
In-Reply-To: <CAJD7tkbhy=JUFsFbGuG7OKgEcLSdCaBBtL-bZn92sP6Wk_sN4A@mail.gmail.com>
References: <20230303073130.1950714-1-senozhatsky@chromium.org>
        <20230303073130.1950714-3-senozhatsky@chromium.org>
        <CAJD7tka5VnRBUnpzoAX6eNuRocSbdGFBfmEx1pxQaDHT9UyMtg@mail.gmail.com>
        <CAJD7tkbhy=JUFsFbGuG7OKgEcLSdCaBBtL-bZn92sP6Wk_sN4A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 3 Mar 2023 08:58:55 -0800 Yosry Ahmed <yosryahmed@google.com> wrote:

> > > +               for (fg = ZS_INUSE_RATIO_70; fg <= ZS_INUSE_RATIO_99; fg++)
> > > +                       class_almost_full = zs_stat_get(class, fg);
> > > +               for (fg = ZS_INUSE_RATIO_10; fg < ZS_INUSE_RATIO_70; fg++)
> > > +                       class_almost_empty = zs_stat_get(class, fg);
> >
> > Aren't these supposed to be += ?
> 
> Looks like they are removed by a following patch anyway.

I'll fix that up anyway, to avoid a bisection hole.  And in case [patch 4/4]
gets dropped from the series or is later reverted or whatever.