Date:   Fri, 3 Mar 2023 16:46:03 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Jason Wang <jasowang@redhat.com>, rbradford@rivosinc.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] virtio-net: Fix probe of virtio-net on kvmtool
Message-ID: <20230303164603.7b35a76f@kernel.org>
In-Reply-To: <20230302044806-mutt-send-email-mst@kernel.org>
References: <20230223-virtio-net-kvmtool-v3-1-e038660624de@rivosinc.com>
        <20230301093054-mutt-send-email-mst@kernel.org>
        <CACGkMEsG10CWigz+S6JgSVK8XfbpT=L=30hZ8LDvohtaanAiZQ@mail.gmail.com>
        <20230302044806-mutt-send-email-mst@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2 Mar 2023 04:48:38 -0500 Michael S. Tsirkin wrote:
> > Looks not the core can try to enable and disable features according to
> > the diff between features and hw_features
> > 
> > static inline netdev_features_t netdev_get_wanted_features(
> >         struct net_device *dev)
> > {
> >         return (dev->features & ~dev->hw_features) | dev->wanted_features;
> > }
> 
> yes what we do work according to code.  So the documentation is wrong then?

It's definitely incomplete but which part are you saying is wrong?