Subject: Re: [PATCH] Add macros for acessing lguest fields
From: Rusty Russell <rusty@rustcorp.com.au>
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
       rostedt@goodmiss.org, virtualization@lists.linux-foundation.org,
       lguest@ozlabs.org, glommer@gmail.com
In-Reply-To: <11894484404160-git-send-email-gcosta@redhat.com>
References: <11894484404160-git-send-email-gcosta@redhat.com>
Content-Type: text/plain
Date: Thu, 13 Sep 2007 16:32:53 +1000
Message-Id: <1189665173.32322.17.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 842
Lines: 23

On Mon, 2007-09-10 at 15:20 -0300, Glauber de Oliveira Costa wrote:
> The assumption that we have an overall irqs_pending flags,
> and a one-to-one lguest <-> task mapping fails to hold on x86_64,
> where we can have multiple puppies, aka vcpus.
> 
> Although ifdefs could be used, it makes the code much more
> unreadable, and other ports are on the way, anyway. So some sort
> of acessor is preferred anyway.

I'd prefer to see the i386 code use vcpus too.  Even if i386 only has
one at present, it's cleaner.

Of course, there'll be a lot of "s/lg/vcpu/" churn, but that's OK.

Thanks,
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/