Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762134AbXIMGm7 (ORCPT ); Thu, 13 Sep 2007 02:42:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752048AbXIMGmv (ORCPT ); Thu, 13 Sep 2007 02:42:51 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:46384 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753883AbXIMGmv (ORCPT ); Thu, 13 Sep 2007 02:42:51 -0400 Message-ID: <46E8DBE3.7040204@garzik.org> Date: Thu, 13 Sep 2007 02:42:43 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: Alexey Dobriyan CC: Andrew Morton , Greg KH , Kees Cook , linux-kernel@vger.kernel.org, Ben Collins , Michael Wu Subject: Re: [PATCH] pci: fix unterminated pci_device_id lists References: <20070912064134.GO7910@outflux.net> <46E7C91D.3070001@garzik.org> <20070912215356.GC23294@kroah.com> <20070912160827.e359a53b.akpm@linux-foundation.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 954 Lines: 27 Alexey Dobriyan wrote: > -static struct pci_device_id rtl8139_pci_tbl[] = { > +PCI_MODULE_DEVICE_TABLE_BEGIN(rtl8139_pci_tbl) > {0x10ec, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, > {0x10ec, 0x8138, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, > {0x1113, 0x1211, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, > @@ -273,10 +273,7 @@ static struct pci_device_id rtl8139_pci_tbl[] = { > {PCI_ANY_ID, 0x8139, 0x10ec, 0x8139, 0, 0, RTL8139 }, > {PCI_ANY_ID, 0x8139, 0x1186, 0x1300, 0, 0, RTL8139 }, > {PCI_ANY_ID, 0x8139, 0x13d1, 0xab06, 0, 0, RTL8139 }, > - > - {0,} > -}; > -MODULE_DEVICE_TABLE (pci, rtl8139_pci_tbl); > +PCI_MODULE_DEVICE_TABLE_END I think the previous version looks better. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/