Message-ID: <d01112c2-b5a4-4aa3-4ee7-711abc9da079@infradead.org>
Date:   Sat, 4 Mar 2023 09:56:08 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 1/2] menuconfig: delete shadows, reclaim vertical space
Content-Language: en-US
To:     Alexey Dobriyan <adobriyan@gmail.com>,
        Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
References: <94a94ef4-9d55-4293-8363-3c0243eceae1@p183>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <94a94ef4-9d55-4293-8363-3c0243eceae1@p183>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 3/4/23 08:55, Alexey Dobriyan wrote:
> Menuconfig has lots of vertical space wasted: on my system there are
> 17 lines of useful information about config options and 14 lines of
> useless fluff: legend, horizontal separators and shadows.
> 
> Sitation is even worse on smaller terminals because fixed vertical lines
> do not go away, but config option lines do decreasing informational
> density even more.
> 
> Delete shadows and increase menu size to reclaim vertical space.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  scripts/kconfig/lxdialog/checklist.c |    2 --
>  scripts/kconfig/lxdialog/dialog.h    |    1 -
>  scripts/kconfig/lxdialog/inputbox.c  |    2 --
>  scripts/kconfig/lxdialog/menubox.c   |    6 ++----
>  scripts/kconfig/lxdialog/textbox.c   |    2 --
>  scripts/kconfig/lxdialog/util.c      |   22 ----------------------
>  scripts/kconfig/lxdialog/yesno.c     |    2 --
>  7 files changed, 2 insertions(+), 35 deletions(-)
> 

This patch works for me, but since the right side shadow is
also being removed, the one column (width) that it had
occupied might as well be used (reclaimed) instead of just
going to waste.

Thanks.
-- 
~Randy