Date:   Sat, 4 Mar 2023 21:53:14 +0300
From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Masahiro Yamada <masahiroy@kernel.org>,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] menuconfig: reclaim 1 more vertical line
Message-ID: <a5a4bfb5-90ec-447f-82a2-28804e3353b0@p183>
References: <94a94ef4-9d55-4293-8363-3c0243eceae1@p183>
 <8a8c8ed8-f322-4024-9433-3a9cb524484e@p183>
 <ae258f1e-5c44-d349-4704-fbf5c7c28b85@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ae258f1e-5c44-d349-4704-fbf5c7c28b85@infradead.org>
Precedence: bulk

On Sat, Mar 04, 2023 at 09:52:55AM -0800, Randy Dunlap wrote:
> Hi,
> 
> On 3/4/23 08:56, Alexey Dobriyan wrote:
> > Empty line after legend is waste, use it for config options.
> > 
> 
> I don't see an empty line after the legend. For me this patch
> truncates the menu_instructions[] text from 4 lines to 3 lines,
> dropping good/useful help text.

OK, I do need to test this one on more screen sizes.

> menu_instructions[] was already truncated before this patch
> (in an 80x30 size terminal window).
> 
> What size terminal are you using?

135 x 31

> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > ---
> > 
> >  scripts/kconfig/lxdialog/menubox.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- a/scripts/kconfig/lxdialog/menubox.c
> > +++ b/scripts/kconfig/lxdialog/menubox.c
> > @@ -185,7 +185,7 @@ int dialog_menu(const char *title, const char *prompt,
> >  
> >  	height -= 2;
> >  	width  -= 5;
> > -	menu_height = height - 10;
> > +	menu_height = height - 9;
> >  
> >  	max_choice = MIN(menu_height, item_count());
> >  
> 
> -- 
> ~Randy