Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A30C678DB for ; Sat, 4 Mar 2023 21:03:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229618AbjCDVDe (ORCPT ); Sat, 4 Mar 2023 16:03:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbjCDVDb (ORCPT ); Sat, 4 Mar 2023 16:03:31 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEE70D502 for ; Sat, 4 Mar 2023 13:03:26 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id cy23so23535454edb.12 for ; Sat, 04 Mar 2023 13:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1677963805; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fc3ttMvepwzFWVo6udVksEFHtSzqK6XOPV7RiZqfde4=; b=OVRr1Xtm41f/Vcw9KhdqRl13hClLRcHXk2rZiZ3Qck7HP1jNEgIxGULY0Sb4GJVFGd bH8EektFMUsW3uMwDxV5gDamyvJvjxzHGLRA6Ivi2/gmB7JwTmFgoqcrPQgyVOAD5T6j A5eLHbfnfikk+mTusCd/h+LXQwxlc4pPJ9tXg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677963805; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fc3ttMvepwzFWVo6udVksEFHtSzqK6XOPV7RiZqfde4=; b=BdbseSZthY/cmX4ziuK+8sJxtJkVNGinOB3tmk2nuK8hkz5uKhcw6aqvsk08QGw+wb VpCTTvwDI91YHk3D8auAUPYSp9ay20wQ3y86KwgdbxvkneAw/DxjwCNn9vZkd8jbp3gg IyxmZ/nT+91jIU7PI+W9Ck87fBLv9OdqoXd33oz+VV+ZhemGR3pAdZhetu+GJ4hErWp7 EXQcHObrtr7TQE6NY7WSOMFj0G3sPGR/mxRbUlBxr7/0Gk9oHaU28BSgv7Hzonu7vLDi segX0MU0VAllP9jCKik9pFzKC808/fB93CDFhkojaupK2l34DwBKeBG+DlALQ36t1Y7N k2PQ== X-Gm-Message-State: AO0yUKX8W7pimKuPsY/UlpYitO48fxYbA6PBDpR8qEz2ZHlJnVZhpCic ANVeB4xL2d26tRf5zq/LRbIdRZLmpxlJoRMAau2y7g== X-Google-Smtp-Source: AK7set8qknzW/9gW6SwKrU6+mpNC4TwlgBznw7pKUE6MTHxD17fFie1OxlqStMBQugH4hWwzLasRHw== X-Received: by 2002:aa7:c552:0:b0:4cf:350e:3459 with SMTP id s18-20020aa7c552000000b004cf350e3459mr4116152edr.25.1677963805043; Sat, 04 Mar 2023 13:03:25 -0800 (PST) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com. [209.85.208.52]) by smtp.gmail.com with ESMTPSA id i6-20020a17090671c600b008b26f3d45fbsm2451660ejk.143.2023.03.04.13.03.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Mar 2023 13:03:24 -0800 (PST) Received: by mail-ed1-f52.google.com with SMTP id ay14so19982068edb.11 for ; Sat, 04 Mar 2023 13:03:24 -0800 (PST) X-Received: by 2002:a17:906:d041:b0:877:747d:4a82 with SMTP id bo1-20020a170906d04100b00877747d4a82mr2890993ejb.0.1677963804011; Sat, 04 Mar 2023 13:03:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Sat, 4 Mar 2023 13:03:06 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/2] vfs: avoid duplicating creds in faccessat if possible To: Yury Norov Cc: Mateusz Guzik , Alexander Potapenko , Al Viro , Kees Cook , Eric Biggers , Christian Brauner , serge@hallyn.com, paul@paul-moore.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 4, 2023 at 1:01=E2=80=AFPM Linus Torvalds wrote: > > Silly useless cases are just that - silly and useless. They should not > be arguments for the real cases then being optimized and simplified. There's a missing "not" above, that was hopefully obvious from the context: "They should not be arguments for the real cases then NOT being optimized and simplified" Linus