Message-ID: <ed3f46b20241a87f666a92441383e7fa55d9eadb.camel@perches.com>
Subject: Re: [PATCH] drm/amd/display: Simplify same effect if/else blocks
From:   Joe Perches <joe@perches.com>
To:     Harry Wentland <harry.wentland@amd.com>,
        Deepak R Varma <drv@mailo.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc:     Leo Li <sunpeng.li@amd.com>,
        Christian =?ISO-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Date:   Sat, 04 Mar 2023 15:48:05 -0800
In-Reply-To: <4d670a5c-b680-ba76-a640-88b3d945c0b0@amd.com>
References: <Y8POxreeC3EvOXhC@ubun2204.myguest.virtualbox.org>
         <33ecbe8971bb9c90d72c67d43ca740abac160908.camel@perches.com>
         <Y82GHzOUHgEqTUq7@ubun2204.myguest.virtualbox.org>
         <Y/+z22xM7NNjX8VP@ubun2204.myguest.virtualbox.org>
         <f15b10a8-11f6-6c1f-c94e-71796aad9155@amd.com>
         <4d670a5c-b680-ba76-a640-88b3d945c0b0@amd.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-03-03 at 15:35 -0500, Harry Wentland wrote:
> Actually I was wrong. Too many similar-looking snippets in this
> function made me look at the wrong thing. This change is fine and
> Reviewed-by: Harry Wentland <harry.wentland@amd.com.

So why was the change made in the first place?

Please explain commit 9114b55fabae.