Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Joel Fernandes <joel@joelfernandes.org>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH 13/13] rcu/kvfree: Eliminate k[v]free_rcu() single argument macro
Date:   Sun, 5 Mar 2023 07:56:33 -0500
Message-Id: <D8B84631-860B-41CF-8311-88E220C7254F@joelfernandes.org>
References: <ZAR//FKO4syzapk6@pc636>
Cc:     "Paul E . McKenney" <paulmck@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, RCU <rcu@vger.kernel.org>,
        Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>,
        Jens Axboe <axboe@kernel.dk>,
        Philipp Reisner <philipp.reisner@linbit.com>,
        Bryan Tan <bryantan@vmware.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Eric Dumazet <edumazet@google.com>,
        Bob Pearson <rpearsonhpe@gmail.com>,
        Ariel Levkovich <lariel@nvidia.com>,
        Theodore Ts'o <tytso@mit.edu>, Julian Anastasov <ja@ssi.bg>
In-Reply-To: <ZAR//FKO4syzapk6@pc636>
To:     Uladzislau Rezki <urezki@gmail.com>
Precedence: bulk


> On Mar 5, 2023, at 6:41 AM, Uladzislau Rezki <urezki@gmail.com> wrote:
>=20
> =EF=BB=BF
>>=20
>>>> On Mar 5, 2023, at 5:29 AM, Joel Fernandes <joel@joelfernandes.org> wro=
te:
>>>=20
>>> =EF=BB=BFHi, All,
>>>=20
>>>> On Wed, Feb 1, 2023 at 10:11=E2=80=AFAM Uladzislau Rezki (Sony)
>>>> <urezki@gmail.com> wrote:
>>>>=20
>>>> For a single argument invocations a new kfree_rcu_mightsleep()
>>>> and kvfree_rcu_mightsleep() macroses are used. This is done in
>>>> order to prevent users from calling a single argument from
>>>> atomic contexts as "_mightsleep" prefix signals that it can
>>>> schedule().
>>>>=20
>>>=20
>>> Since this commit in -dev branch [1] suggests more users still need
>>> conversion, let us drop this single patch for 6.4 and move the rest of
>>> the series forward? Let me know if you disagree.
>>> https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/co=
mmit/?h=3Ddev&id=3D9bf5e3a2626ed474d080f695007541b6ecd6e60b
>>>=20
>>> All -- please supply Ack/Review tags for patches 1-12.
>>=20
>> Or put another way, what is the transition plan for these remaining users=
?
>>=20
>> I am getting on a plane right now but I can research which users are rema=
ining later.
>>=20
> I am not sure. I think we can cover it on the meeting.

Cool, thanks.

> My feeling is
> that, we introduced "_mightsleep" macros first and after that try to
> convert users.

One stopgap could be to add a checkpatch error if anyone tries to use old AP=
I,
and then in the meanwhile convert all users.
Though, that requires people listening to checkpatch complaints.

Thanks,

 - Joel


>=20
> @Paul what is your view?
>=20
> Thanks!
>=20
> --
> Uladzislau Rezki