Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH 2/2] arm64: dts: meson: add support for BananaPi M2S
 variants
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <0d2184ee-679e-371e-8433-c38b22c97799@linaro.org>
Date:   Sun, 5 Mar 2023 17:47:38 +0400
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Linux Amlogic <linux-amlogic@lists.infradead.org>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <9CC246C2-28A7-46DF-924F-8FBF5CDE16CA@gmail.com>
References: <20230305132044.1596320-1-christianshewitt@gmail.com>
 <20230305132044.1596320-3-christianshewitt@gmail.com>
 <0d2184ee-679e-371e-8433-c38b22c97799@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Precedence: bulk


> On 5 Mar 2023, at 5:30 pm, Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org> wrote:
>=20
> On 05/03/2023 14:20, Christian Hewitt wrote:
>> BananaPi M2S ships in Amlogic S922X and A311D variants with the
>> following common specifications:
>>=20
> (...)
>=20
>> +
>> +	leds {
>> +		compatible =3D "gpio-leds";
>> +
>> +		blue {
>=20
> led-0
>=20
> Does not look like you tested the DTS against bindings. Please run =
`make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).

I=E2=80=99m building everything in a cross-compile build system that =
doesn=E2=80=99t allow
this to be done without a problem amount of hoop jumping. I need to work =
on
another arrangement to do this testing (work-in-progress). Thanks for =
the
input.

Christian

>> +			color =3D <LED_COLOR_ID_BLUE>;
>> +			function =3D LED_FUNCTION_STATUS;
>> +			gpios =3D <&gpio_ao GPIOAO_7 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger =3D "heartbeat";
>> +		};
>> +
>> +		green {
>=20
> led-1
>=20
>> +			color =3D <LED_COLOR_ID_GREEN>;
>> +			function =3D LED_FUNCTION_STATUS;
>> +			gpios =3D <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
>> +		};
>=20
> Best regards,
> Krzysztof
>=20