MIME-Version: 1.0
References: <20230305135207.1793266-1-sashal@kernel.org> <20230305135207.1793266-7-sashal@kernel.org>
In-Reply-To: <20230305135207.1793266-7-sashal@kernel.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Sun, 5 Mar 2023 14:59:11 +0100
Message-ID: <CAMuHMdXLBVDPPM5ZGGV5O5uMm4R8=ZHvsgDxMxHQP2q4YKvhhA@mail.gmail.com>
Subject: Re: [PATCH AUTOSEL 6.2 07/16] clk: renesas: rcar-gen3: Disable R-Car
 H3 ES1.*
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        mturquette@baylibre.com, sboyd@kernel.org,
        linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Sasha,

On Sun, Mar 5, 2023 at 2:52 PM Sasha Levin <sashal@kernel.org> wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> [ Upstream commit b1dec4e78599a2ce5bf8557056cd6dd72e1096b0 ]
>
> R-Car H3 ES1.* was only available to an internal development group and
> needed a lot of quirks and workarounds. These become a maintenance
> burden now, so our development group decided to remove upstream support
> for this SoC. Public users only have ES2 onwards.
>
> In addition to the ES1 specific removals, a check for it was added
> preventing the machine to boot further. It may otherwise inherit wrong
> clock settings from ES2 which could damage the hardware.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Link: https://lore.kernel.org/r/20230202092332.2504-1-wsa+renesas@sang-engineering.com
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

This patch disables hardware support.  Do we really want to backport
that to stable?
Perhaps backporting to v6.2.y and v6.1.y is still acceptable (the next
Renesas BSP will be based on v6.1.y LTS), but I would not recommend
backporting to older versions.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds