Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH 2/2] arm64: dts: meson: add support for BananaPi M2S
 variants
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <e52c4a1d-951e-8ce5-4aec-7f2b6d4c6c3a@linaro.org>
Date:   Sun, 5 Mar 2023 18:31:10 +0400
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Linux Amlogic <linux-amlogic@lists.infradead.org>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <82FF9933-B4CF-428B-9EB7-40FCBD285EEE@gmail.com>
References: <20230305132044.1596320-1-christianshewitt@gmail.com>
 <20230305132044.1596320-3-christianshewitt@gmail.com>
 <0d2184ee-679e-371e-8433-c38b22c97799@linaro.org>
 <9CC246C2-28A7-46DF-924F-8FBF5CDE16CA@gmail.com>
 <e52c4a1d-951e-8ce5-4aec-7f2b6d4c6c3a@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Precedence: bulk


> On 5 Mar 2023, at 6:15 pm, Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org> wrote:
>=20
> On 05/03/2023 14:47, Christian Hewitt wrote:
>>=20
>>> On 5 Mar 2023, at 5:30 pm, Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org> wrote:
>>>=20
>>> On 05/03/2023 14:20, Christian Hewitt wrote:
>>>> BananaPi M2S ships in Amlogic S922X and A311D variants with the
>>>> following common specifications:
>>>>=20
>>> (...)
>>>=20
>>>> +
>>>> +	leds {
>>>> +		compatible =3D "gpio-leds";
>>>> +
>>>> +		blue {
>>>=20
>>> led-0
>>>=20
>>> Does not look like you tested the DTS against bindings. Please run =
`make
>>> dtbs_check` (see =
Documentation/devicetree/bindings/writing-schema.rst
>>> for instructions).
>>=20
>> I=E2=80=99m building everything in a cross-compile build system that =
doesn=E2=80=99t allow
>> this to be done without a problem amount of hoop jumping. I need to =
work on
>> another arrangement to do this testing (work-in-progress). Thanks for =
the
>=20
> Cross compiling kernel and running this (also as cross compiled) is
> trivial, so what exactly stops you? Packaging kernel for your system
> (e.g. Yocto) is different topic, but that's final step, not necessary
> for development of DTS.

I=E2=80=99m reasonably competent within the constraints of the distro =
build-system
environment that I use and know. I=E2=80=99m very lacking in knowledge =
if you step
outside that. It=E2=80=99s mostly an old-dog/new-trick problem, and =
something I do
need to improve upon (not a good excuse, I know).

Christian=