Date:   Mon, 6 Mar 2023 10:55:46 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Lee Jones <lee@kernel.org>
CC:     Wolfram Sang <wsa@kernel.org>, Tyrone Ting <kfting@nuvoton.com>,
        "Mark Brown" <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>, <linux-usb@vger.kernel.org>,
        <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-spi@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <srinivas.pandruvada@intel.com>, <heikki.krogerus@linux.intel.com>,
        <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <zhifeng.wang@intel.com>,
        <wentong.wu@intel.com>, <lixu.zhang@intel.com>
Subject: Re: [PATCH 1/5] mfd: Add support for Intel LJCA device
Message-ID: <ZAVWMp2LyxY7w6N0@ye-NUC7i7DNHE>
References: <20230219183059.1029525-1-xiang.ye@intel.com>
 <20230219183059.1029525-2-xiang.ye@intel.com>
 <20230305103456.GF2574592@google.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230305103456.GF2574592@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0N2S2VReHFqcXdBVndmdkZHZ29icFJ0cmJraW8zMlVDWjFDOFlNTjY2cXZT?=
 =?utf-8?B?L20vV25jOGl1NkJrdlAydTV2V1ZOTktBQXVZZEVxYWV0VUdobEU3dnRhdXNB?=
 =?utf-8?B?eTJPR3I0dCtoQWJmM0pSWjNmUkdWY3RtNmJlbE1pZStIOUwvU1c0KzZPYzl4?=
 =?utf-8?B?a1J3SVQwY05wOGtWNmJlUFIwY1QzYnJCVjA5Zm1MSFg4bEJGOUw4Wko0V1Bz?=
 =?utf-8?B?UElGaGVTeWtlNEtWQ2JucXJQK001WTA3dHdYMU10eUlRcVZzN084d256T2da?=
 =?utf-8?B?U3ozenRmWEU4cUNFV0Z4MDJkM1ljdEorL0ErejBPTVJuaUtLS2JPSFFCUUxh?=
 =?utf-8?B?U3haWHErNnpNRkZGMDB0Mm4wVllCcDQ2c2Z6UG9nNjZIWVdwTVQrNFpyd0xK?=
 =?utf-8?B?N1BZWHo4N0h5dE02b0JCKzIwb0NVZzdkeDZwZ3Nlcis1VmxRMUVUN2NqY2R4?=
 =?utf-8?B?WjBpMUdyMTgxRjQwSW1GOG42cXRWR1pIKzdaVkxtS3RkZGRrVzFkTWx1RXhT?=
 =?utf-8?B?M1ZqMjJKbXZxdk5POGszVWNkNmN0ZHgzV2c1c1c5TnIvamNsdE5XeXBlYktN?=
 =?utf-8?B?SlNLOGUxTXpwcFlueXpOUlh1TEhVV1dqb0hJVkEreklMMjd3VW96TmNEMUx1?=
 =?utf-8?B?ZVdxVEhCa1AxRFovVGlySmN4Ri9KSzdhSlJMdmpVTEtuMnJqZXMyamRsdWxl?=
 =?utf-8?B?OUlwNDZkcW14S3dhSEJLTUdSNm1ZL2YxYnI2T3pwNGxmcTlDdHV0VnZPaUdM?=
 =?utf-8?B?OFpRVGRiSzZITlgzcmdFWkRmUCszaHVKMTQ0MkFkUjg1RUkxdVZQZjVjMUZP?=
 =?utf-8?B?V1A4SVNTS3dJVUc1K21PNE8ySzh6dTFDZUI2amN3MFJjaWIrZUZPWmJnZi9j?=
 =?utf-8?B?U3BHTEZqaWZXVVBhbUUrSzNhVHdNY1N6TStFNVkzSllLZjBSY3UxTzIyYzdP?=
 =?utf-8?B?d1RGOEo1alZwMTZQRENoOWVvUm1KRlVuS3J4R1N4YnFQZ0M3SFkzYllybW43?=
 =?utf-8?B?SUtYeVJiVlo0TVFpQVRJTVAxRitLQUNrRnQ5akhoNnhLUU55blhuNU9zR3h0?=
 =?utf-8?B?MzB6eGY2NU1LTTJmN0NZK1BNaFNyeWVtTFRhZ2JzVFI1VU8wTUg0QnhQc0pX?=
 =?utf-8?B?RUJ6KzVGdFBETHV5NDlrYlRQdGRMblUrWml2NWNVbGZKUkhRcU85ZVloeEla?=
 =?utf-8?B?WS9QdE9KYVFSVjNIVFRsWHR0TkZSV0hsbm1FcnNNQkYxMGtZY0Y1Z0owM1JZ?=
 =?utf-8?B?VGZ3TSt3dGYzTzNGdWw2c1JKZkxKK2oycUVJNDJkd0dkcC85VWlaaG1Semk2?=
 =?utf-8?B?SDZTOU1YNUFUSCtXY1lXWmZmRWltV2tvMkpyNzhqSWt0UkJBVFh3MllGd0d3?=
 =?utf-8?B?bXZBbDdJSWtSajBkSXdKSGNTLzBmWlNYR2w5MjB1VHJvL0w1ekY5cnF5eGs3?=
 =?utf-8?B?VzJUOVlGdzI0RjQvdE1mZ05hWGI3aTJYdlhiUWVnMWVxSVJKYjVwZ1oyZVFX?=
 =?utf-8?B?bjVGQVVaV0piMzVkdWdSaG4zVDJXelNidG1QNUo4MWMrTU9iL3E0a21OMldq?=
 =?utf-8?B?YzFwSGtuTHJySFZMSVlqcGh4Yy9qTHdva0F0ejlLOS9LZFZxZ3hoYzhEU2pK?=
 =?utf-8?B?T2JjSFZ2UWV1R3BzQzlWTlZiaEZKOTlaZmlUTlFnbGFVUjVhTVR1V3BDTTI1?=
 =?utf-8?B?K2o0cmY2MmNsSzE3ZSttNFUwMzI4OHkwZnpNVjZCMXlzYmpNZ1RYYkFEK0ti?=
 =?utf-8?B?TndrR0EzdDVCNnd5MGRnL1pJRnIwU0ZzOHVmMngyQ3pueHJvWEJocnJKdVFB?=
 =?utf-8?B?RnJnbkdWN0crcjdQSmY4SWx3dXAxLzZ0Y2pTWkRKcmFRY3d2K2kwZnJLb0Vx?=
 =?utf-8?B?U214MExjT0FLakgwcWVSRkVoZ2M0b1R2alRGTXdyVTM2d08rMGpRNHd2SUZy?=
 =?utf-8?B?Zis4dUgycFpyRHNic2xpa3pEWWVjZ0pGVTBoTW55cFVPNDIxZ3lLdkVwNzY2?=
 =?utf-8?B?RXpIR3ZIVm9KUG9LREdUWmdiM012bkNnaE9oTWtGSFNVc3Era3JZNlZpMFdP?=
 =?utf-8?B?VW0xYXljOE9JdXcvUS9xWU96YlVudG9qcW40WU5VbGp0b0NSSWhlclcycUZs?=
 =?utf-8?Q?6fpxEc/ZX1zPDrjs40YpAb3I8?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 371538ce-892c-44c3-8c8c-08db1dee4ce9
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1418.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 02:55:53.5353
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iQALXBoVKDaICIcMFIfOHfDw8MYc9QMMfvV1XE9hMuxRK4sYPbfDoBBUFB18DrWzeyR1h4YRPVjg0VnKtefcfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5350
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lee,

Thanks for the review.
On Sun, Mar 05, 2023 at 10:34:56AM +0000, Lee Jones wrote:
> On Mon, 20 Feb 2023, Ye Xiang wrote:
> 
> > This patch implements the USB part of Intel USB-I2C/GPIO/SPI adapter
> > device named "La Jolla Cove Adapter" (LJCA).
> 
> The "USB part" should live in drivers/usb.
What about putting ljca.c to drivers/usb/misc?
> 
> You can use MFD to register each of the components, but all of the USB
> functionality needs moving somewhere else.
Ok, Now the USB functionality drivers have already been put to related driver
folders: spi-ljca in drivers/spi, i2c-ljca in drivers/i2c, and gpio-ljca
in drivers/gpio.
>  
> > The communication between the various LJCA module drivers and the
> > hardware will be muxed/demuxed by this driver. The sub-module of
> > LJCA can use ljca_transfer() to issue a transfer between host
> > and hardware.
> > 
> > Each sub-module of LJCA device is identified by type field within
> > the LJCA message header.
> > 
> > The minimum code in ASL that covers this board is
> > Scope (\_SB.PCI0.DWC3.RHUB.HS01)
> >     {
> >         Device (GPIO)
> >         {
> >             Name (_ADR, Zero)
> >             Name (_STA, 0x0F)
> >         }
> > 
> >         Device (I2C)
> >         {
> >             Name (_ADR, One)
> >             Name (_STA, 0x0F)
> >         }
> > 
> >         Device (SPI)
> >         {
> >             Name (_ADR, 0x02)
> >             Name (_STA, 0x0F)
> >         }
> >     }
> > 
> > Signed-off-by: Ye Xiang <xiang.ye@intel.com>
> > ---
> >  drivers/mfd/Kconfig      |  13 +
> >  drivers/mfd/Makefile     |   1 +
> >  drivers/mfd/ljca.c       | 977 +++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/ljca.h |  95 ++++
> >  4 files changed, 1086 insertions(+)
> >  create mode 100644 drivers/mfd/ljca.c
> >  create mode 100644 include/linux/mfd/ljca.h
> 
> -- 
> Lee Jones [李琼斯]