MIME-Version: 1.0
References: <20230221025347.389047-1-imagedong@tencent.com>
 <20230221025347.389047-3-imagedong@tencent.com> <CAEf4Bzac+SmdosLf=nnieuEBx6azVTg1_fVNWScsWb9-Hap6pw@mail.gmail.com>
In-Reply-To: <CAEf4Bzac+SmdosLf=nnieuEBx6azVTg1_fVNWScsWb9-Hap6pw@mail.gmail.com>
From:   Menglong Dong <menglong8.dong@gmail.com>
Date:   Mon, 6 Mar 2023 11:40:39 +0800
Message-ID: <CADxym3YT1JGQ+ZiwLrfrBz_J=4XPNv-7ic+9mMyaCHwDyQARdw@mail.gmail.com>
Subject: Re: [PATCH bpf-next v3 2/3] selftests/bpf: split test_attach_probe
 into multi subtests
To:     Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc:     alan.maguire@oracle.com, ast@kernel.org, daniel@iogearbox.net,
        andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
        yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
        sdf@google.com, haoluo@google.com, jolsa@kernel.org,
        benbjiang@tencent.com, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, Menglong Dong <imagedong@tencent.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Feb 28, 2023 at 5:53=E2=80=AFAM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Mon, Feb 20, 2023 at 6:54=E2=80=AFPM <menglong8.dong@gmail.com> wrote:
> >
> > From: Menglong Dong <imagedong@tencent.com>
> >
> > In order to adapt to the older kernel, now we split the "attach_probe"
> > testing into multi subtests:
> >
> >   manual // manual attach tests for kprobe/uprobe
> >   auto // auto-attach tests for kprobe and uprobe
> >   kprobe-sleepable // kprobe sleepable test
> >   uprobe-lib // uprobe tests for library function by name
> >   uprobe-sleepable // uprobe sleepable test
> >   uprobe-ref_ctr // uprobe ref_ctr test
> >
> > As sleepable kprobe needs to set BPF_F_SLEEPABLE flag before loading,
> > we need to move it to a stand alone skel file, in case of it is not
> > supported by kernel and make the whole loading fail.
> >
> > Therefore, we can only enable part of the subtests for older kernel.
> >
> > Reviewed-by: Biao Jiang <benbjiang@tencent.com>
> > Signed-off-by: Menglong Dong <imagedong@tencent.com>
> > Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
> > ---
> > v3:
> > - rename test_uporbe_ref_ctr() to test_uprobe_ref_ctr() to fix the
> >   typo
> > ---
>
>
> One of the patches in this patch set broke BPF CI ([0]), please take a lo=
ok
>
>   [0] https://github.com/kernel-patches/bpf/actions/runs/4267719970/jobs/=
7429701318
>

It is caused by the fact that I didn't use OPTS_GET(), as you mentioned
before.

> >  .../selftests/bpf/prog_tests/attach_probe.c   | 268 +++++++++++-------
> >  .../bpf/progs/test_attach_kprobe_sleepable.c  |  23 ++
> >  .../selftests/bpf/progs/test_attach_probe.c   |  23 +-
> >  3 files changed, 208 insertions(+), 106 deletions(-)
> >  create mode 100644 tools/testing/selftests/bpf/progs/test_attach_kprob=
e_sleepable.c
> >
>
> [...]