Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758502AbXIMKZm (ORCPT ); Thu, 13 Sep 2007 06:25:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751914AbXIMKZe (ORCPT ); Thu, 13 Sep 2007 06:25:34 -0400 Received: from gir.skynet.ie ([193.1.99.77]:39875 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbXIMKZd (ORCPT ); Thu, 13 Sep 2007 06:25:33 -0400 Date: Thu, 13 Sep 2007 11:25:31 +0100 To: Christoph Lameter Cc: Lee.Schermerhorn@hp.com, kamezawa.hiroyu@jp.fujitsu.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/6] Filter based on a nodemask as well as a gfp_mask Message-ID: <20070913102531.GF22778@skynet.ie> References: <20070912210444.31625.65810.sendpatchset@skynet.skynet.ie> <20070912210625.31625.36220.sendpatchset@skynet.skynet.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) From: mel@skynet.ie (Mel Gorman) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1043 Lines: 35 On (12/09/07 14:23), Christoph Lameter didst pronounce: > On Wed, 12 Sep 2007, Mel Gorman wrote: > > > - z++) > > - ; > > + if (likely(nodes == NULL)) > > + for (; zonelist_zone_idx(z) > highest_zoneidx; > > + z++) > > + ; > > + else > > + for (; zonelist_zone_idx(z) > highest_zoneidx || > > + (z->zone && !zref_in_nodemask(z, nodes)); > > + z++) > > + ; > > > > Minor nitpick here: "for (;" should become "for ( ;" to have correct > whitespace. However, it would be clearer to use a while here. > > while (zonelist_zone_idx(z)) > highest_zoneidx) > z++; > > etc. Good point. I'll clean it up and retest. Thanks -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/