Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754074AbXIMLyt (ORCPT ); Thu, 13 Sep 2007 07:54:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751699AbXIMLyl (ORCPT ); Thu, 13 Sep 2007 07:54:41 -0400 Received: from ns2.suse.de ([195.135.220.15]:56136 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbXIMLyk (ORCPT ); Thu, 13 Sep 2007 07:54:40 -0400 From: Andi Kleen To: Greg KH Subject: Re: [PATCH] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG is used Date: Thu, 13 Sep 2007 13:53:15 +0200 User-Agent: KMail/1.9.1 Cc: Yinghai Lu , Andrew Morton , Jeff Garzik , Martin Mares , dean gaudet , Robert Richter , Linux Kernel Mailing List References: <200709121921.43950.yinghai.lu@sun.com> <200709131147.43446.ak@suse.de> <20070913104704.GA3878@kroah.com> In-Reply-To: <20070913104704.GA3878@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709131353.15752.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 26 On Thursday 13 September 2007 12:47, Greg KH wrote: > On Thu, Sep 13, 2007 at 11:47:42AM +0200, Andi Kleen wrote: > > On Thursday 13 September 2007 04:21, Yinghai Lu wrote: > > > [PATCH] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG is > > > used. > > > > > > reuse pci_cfg_space_size but skip check pci express and pci-x CAP ID. > > > > I just rejected a similar patch -- this should be done using MMCONFIG > > But what about for broken machines without the proper MMCONFIG entries? > They still need a way to get access to this config space, If there are any devices that need it. IBS and PCI-E error handling do, but they're quite obscure. Also so far we don't know of any Fam 10h systems without MMCONFIG entries. Fam10h requires a new BIOS so it's reasonable to assume that the new BIOSes will do better. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/