Message-ID: <0ef7c77b-723c-461f-1d91-07a5b7701555@huawei.com>
Date:   Mon, 6 Mar 2023 17:17:53 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
CC:     <mawupeng1@huawei.com>, <akpm@linux-foundation.org>,
        <dave.hansen@linux.intel.com>, <luto@kernel.org>,
        <peterz@infradead.org>, <linux-kernel@vger.kernel.org>,
        <x86@kernel.org>
Subject: Re: [PATCH -next 1/2] x86/mm/pat: Move follow_phys to pat-related
 file
To:     <bp@alien8.de>
References: <20230306084316.2275757-1-mawupeng1@huawei.com>
 <20230306084316.2275757-2-mawupeng1@huawei.com>
 <20230306090433.GBZAWsoQJKSpQ0AWYl@fat_crate.local>
Content-Language: en-US
From:   mawupeng <mawupeng1@huawei.com>
In-Reply-To: <20230306090433.GBZAWsoQJKSpQ0AWYl@fat_crate.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/3/6 17:04, Borislav Petkov wrote:
> On Mon, Mar 06, 2023 at 04:43:15PM +0800, Wupeng Ma wrote:
>> From: Ma Wupeng <mawupeng1@huawei.com>
>>
>> Since only PAT in x86 use follow_phys(), move this to from memory.c to
>> memtype.c and make it static. Argument flags is always zero in caller
>> untrack_pfn() and track_pfn_copy(). let's drop it.
>>
>> Since config HAVE_IOREMAP_PROT is selected by x86, drop this config macro.
> 
> * first patch: *only* code movement, no other changes
> * second patch: do semantic changes and explain *why* you do them
> * third patch:...
> *...
> 
> In that order please. Otherwise review is unnecessarily complicated.
> 
> Also, do not talk about *what* the patch is doing in the commit message
> - that should be obvious from the diff itself. Rather, concentrate on
> the *why* it needs to be done.

Hi Borislav.

Thanks for your advise.

I will do what you advised and send a v2 later.

> 
> Thx.
>