MIME-Version: 1.0
References: <20230306024523.248216-1-dzm91@hust.edu.cn>
In-Reply-To: <20230306024523.248216-1-dzm91@hust.edu.cn>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Mon, 6 Mar 2023 10:27:43 +0100
Message-ID: <CAMRc=MdWn_XKZZp9cC056xi8O=ghrZnuX-GAWasWukzDjnM3ow@mail.gmail.com>
Subject: Re: [PATCH] drivers: i2c: remove dead code in davinci_i2c_probe
To:     Dongliang Mu <dzm91@hust.edu.cn>
Cc:     Sekhar Nori <nsekhar@ti.com>, linux-arm-kernel@lists.infradead.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 6, 2023 at 3:48=E2=80=AFAM Dongliang Mu <dzm91@hust.edu.cn> wro=
te:
>
> From the comment of platform_get_irq, it only returns non-zero IRQ
> number and negative error number, other than zero.
>
> Fix this by removing the if condition.
>
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
>  drivers/i2c/busses/i2c-davinci.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-da=
vinci.c
> index c836cf884185..9750310f2c96 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -764,11 +764,8 @@ static int davinci_i2c_probe(struct platform_device =
*pdev)
>         int r, irq;
>
>         irq =3D platform_get_irq(pdev, 0);
> -       if (irq <=3D 0) {
> -               if (!irq)
> -                       irq =3D -ENXIO;
> +       if (irq < 0)
>                 return dev_err_probe(&pdev->dev, irq, "can't get irq reso=
urce\n");
> -       }
>
>         dev =3D devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev),
>                         GFP_KERNEL);
> --
> 2.39.2
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>