MIME-Version: 1.0
References: <20230226205319.1013332-1-dario.binacchi@amarulasolutions.com>
In-Reply-To: <20230226205319.1013332-1-dario.binacchi@amarulasolutions.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Mon, 6 Mar 2023 11:03:38 +0100
Message-ID: <CAMRc=MdoMPROUVeu3m9Jx+-5deRMC9jm+zbGBQ=OdHaLApmJ-g@mail.gmail.com>
Subject: Re: [PATCH] gpio: mxc: use dynamic allocation of base
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>,
        Linus Walleij <linus.walleij@linaro.org>
Cc:     linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Feb 26, 2023 at 9:53=E2=80=AFPM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> Since commit 502df79b860563d7 ("gpiolib: Warn on drivers still using stat=
ic
> gpiobase allocation"), one or more warnings are printed during boot on
> systems where static allocation of GPIO base is used:
>
> [    1.611480] gpio gpiochip0: Static allocation of GPIO base is deprecat=
ed, use dynamic allocation.
> [    1.622893] gpio gpiochip1: Static allocation of GPIO base is deprecat=
ed, use dynamic allocation.
> [    1.633272] gpio gpiochip2: Static allocation of GPIO base is deprecat=
ed, use dynamic allocation.
> [    1.643388] gpio gpiochip3: Static allocation of GPIO base is deprecat=
ed, use dynamic allocation.
> [    1.653474] gpio gpiochip4: Static allocation of GPIO base is deprecat=
ed, use dynamic allocation.
>
> So let's follow the suggestion and use dynamic allocation.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
>  drivers/gpio/gpio-mxc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index 9d0cec4b82a3..abc129a88a62 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -462,8 +462,7 @@ static int mxc_gpio_probe(struct platform_device *pde=
v)
>         port->gc.request =3D gpiochip_generic_request;
>         port->gc.free =3D gpiochip_generic_free;
>         port->gc.to_irq =3D mxc_gpio_to_irq;
> -       port->gc.base =3D (pdev->id < 0) ? of_alias_get_id(np, "gpio") * =
32 :
> -                                            pdev->id * 32;
> +       port->gc.base =3D -1;
>
>         err =3D devm_gpiochip_add_data(&pdev->dev, &port->gc, port);
>         if (err)
> --
> 2.32.0
>

Linus,

I'm afraid we'll need to do something about this warning, because
we're getting the same patch for like 4th time already...

Bart