Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F14C678D4 for ; Mon, 6 Mar 2023 10:04:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229652AbjCFKEH (ORCPT ); Mon, 6 Mar 2023 05:04:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230191AbjCFKEC (ORCPT ); Mon, 6 Mar 2023 05:04:02 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8527412844; Mon, 6 Mar 2023 02:04:00 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2BA6560D36; Mon, 6 Mar 2023 10:04:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77831C433EF; Mon, 6 Mar 2023 10:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678097039; bh=NqMbYyvssKAx59ycEdKMFhaWpef5XSN1pFTGQ0DPAQ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KDfIzHRqSbIPRxQ5kEQXWQNFgsmQ/3ugZts1z8YigEBSh4faCn+rLeqBU6w2tFriP BNIu+8YydqPo4riorBbgxOS7CtqVCqLa6wD9kBbSsh10BujzmsaKnO9x5rtfEEB5ZP CrjBgY61IiuUQIyOL7tTJ8wwjay4MuazLBK/8lIjUw1v5rTby3vl6CMMhl9CV315FM ugCoVWCZAf3kgg1y9ZrCdpSVrR/yFzmlRd4GGXoezELkFnR8jeZcGIeQBDMoxgdlTo hc4aTM3O+wUqG2rTJguyh0O/y219zleqkiBzP4gP+USDs8yUueXwlNh2AzJzEVyu+M yG3K63UQfyD7Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pZ7hv-0007OS-4q; Mon, 06 Mar 2023 11:04:39 +0100 Date: Mon, 6 Mar 2023 11:04:39 +0100 From: Johan Hovold To: Abel Vesa Cc: Johan Hovold , Georgi Djakov , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Konrad Dybcio , Sylwester Nawrocki , Artur =?utf-8?B?xZp3aWdvxYQ=?= , Krzysztof Kozlowski , Alim Akhtar , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 13/23] interconnect: qcom: sm8550: fix registration race Message-ID: References: <20230306075651.2449-1-johan+linaro@kernel.org> <20230306075651.2449-14-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 06, 2023 at 11:39:33AM +0200, Abel Vesa wrote: > On 23-03-06 10:34:34, Johan Hovold wrote: > > On Mon, Mar 06, 2023 at 11:03:14AM +0200, Abel Vesa wrote: > > > On 23-03-06 08:56:41, Johan Hovold wrote: > > > > The current interconnect provider registration interface is inherently > > > > racy as nodes are not added until the after adding the provider. This > > > > can specifically cause racing DT lookups to fail. > > > > > > > > Switch to using the new API where the provider is not registered until > > > > after it has been fully initialised. > > > > > > > > Fixes: e6f0d6a30f73 ("interconnect: qcom: Add SM8550 interconnect provider driver") > > > > Reviewed-by: Abel Vesa > > > > Reviewed-by: Konrad Dybcio > > > > Signed-off-by: Johan Hovold > > > > --- > > > > > > Any changes since v1 or is it just a resend? > > > > Please see the cover letter: > > > > https://lore.kernel.org/lkml/20230306075651.2449-1-johan+linaro@kernel.org/ > > > > Only the first patch of the series was updated in v2. > > Right, my bad. Though I wasn't CC'ed on that as well. Yeah, sorry about that. I copied the CC list from v1 and forgot to make sure that all reviewers were copied on the cover letter. Johan